From: Ira Weiny <ira.weiny@intel.com>
To: Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH RFC 1/2] firmware/efi: Process CXL Component Events
Date: Tue, 17 Oct 2023 19:43:32 -0700 [thread overview]
Message-ID: <652f465489b2b_2bb5d829431@iweiny-mobl.notmuch> (raw)
In-Reply-To: <652f4505231c7_2bb07d29483@iweiny-mobl.notmuch>
Ira Weiny wrote:
> Ira Weiny wrote:
[snip]
> >
> > diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> > index 35c37f667781..af2c59f5e21d 100644
> > --- a/drivers/firmware/efi/cper.c
> > +++ b/drivers/firmware/efi/cper.c
> > @@ -607,6 +607,22 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
> > cper_print_prot_err(newpfx, prot_err);
> > else
> > goto err_section_too_small;
> > + } else if (guid_equal(sec_type, &gen_media_event_guid) ||
> > + guid_equal(sec_type, &dram_event_guid) ||
> > + guid_equal(sec_type, &mem_mod_event_guid)) {
> > + struct cper_cxl_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
>
> Smita,
>
> Dan and I were discussing the processing of these GUIDs vs the UUIDs in the
> trace prints offline.
>
> Here we could separate out the comparisons and use a token for the events
> rather than passing the guid through to be converted into a uuid...
>
Sorry I hit send too soon... Please see my other post.
Ira
[snip]
next prev parent reply other threads:[~2023-10-18 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 6:55 [PATCH RFC 0/2] efi/cxl-cper: Report CPER CXL component events through trace events Ira Weiny
2023-10-13 6:55 ` [PATCH RFC 1/2] firmware/efi: Process CXL Component Events Ira Weiny
2023-10-18 2:37 ` Ira Weiny
2023-10-18 2:43 ` Ira Weiny [this message]
2023-10-18 2:41 ` Ira Weiny
2023-10-13 6:55 ` [PATCH RFC 2/2] cxl/memdev: Register for and process CPER events Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652f465489b2b_2bb5d829431@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).