From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
Shiju Jose <shiju.jose@huawei.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH RFC v4 0/6] efi/cxl-cper: Report CPER CXL component events through trace events
Date: Thu, 09 Nov 2023 14:07:13 -0800 [thread overview]
Message-ID: <20230601-cxl-cper-v4-0-47bb901f135e@intel.com> (raw)
Series status/background
========================
This RFC should be very close to done but I'm still working on getting a
system to test on. Therefore, the CPER code remains compile tested
only. The modified event log code continues to pass cxl-test.
Cover letter
============
CXL Component Events, as defined by EFI 2.10 Section N.2.14, wrap a
mostly CXL event payload in an EFI Common Platform Error Record (CPER)
record. If a device is configured for firmware first CXL event records
are not sent directly to the host.
The CXL sub-system uniquely has DPA to HPA translation information. It
also already has event format tracing. Restructure the code to make
sharing the data between CPER/event logs most efficient. Then send the
CXL CPER records to the CXL sub-system for processing.
With event logs the events interrupt the driver directly. In the EFI
case events are wrapped with device information which needs to be
matched with memdev devices. A number of alternatives were considered
to match the memdev with the CPER record. The most robust was to find
the PCI device via Bus, Device, Function and match it to the memdev
driver data.
CPER records are identified with GUID's while CXL event logs contain
UUID's. The UUID is reported for all events. While the UUID is
redundant for the known events the UUID's are already used by rasdaemon.
To keep compatibility UUIDs are injected for CPER records based on the
record type.
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Changes in v4:
- Jonathan/Shiju: Put UUID back in trace points.
- Smita: Fix packed structure
- Smita: use PCI_DEVFN() properly
- iweiny: update cover letter/commit messages
- Link to v3: https://lore.kernel.org/r/20230601-cxl-cper-v3-0-0189d61f7956@intel.com
---
Ira Weiny (6):
cxl/trace: Pass uuid explicitly to event traces
cxl/events: Promote CXL event structures to a core header
cxl/events: Separate UUID from event structures
cxl/events: Create a CXL event union
firmware/efi: Process CXL Component Events
cxl/memdev: Register for and process CPER events
drivers/cxl/core/mbox.c | 65 ++++++++++------
drivers/cxl/core/trace.h | 34 ++++----
drivers/cxl/cxlmem.h | 96 ++---------------------
drivers/cxl/pci.c | 58 +++++++++++++-
drivers/firmware/efi/cper.c | 15 ++++
drivers/firmware/efi/cper_cxl.c | 40 ++++++++++
drivers/firmware/efi/cper_cxl.h | 29 +++++++
include/linux/cxl-event.h | 160 ++++++++++++++++++++++++++++++++++++++
tools/testing/cxl/test/mem.c | 166 +++++++++++++++++++++++-----------------
9 files changed, 461 insertions(+), 202 deletions(-)
---
base-commit: 1c8b86a3799f7e5be903c3f49fcdaee29fd385b5
change-id: 20230601-cxl-cper-26ffc839c6c6
Best regards,
--
Ira Weiny <ira.weiny@intel.com>
next reply other threads:[~2023-11-09 22:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 22:07 Ira Weiny [this message]
2023-11-09 22:07 ` [PATCH RFC v4 1/6] cxl/trace: Pass uuid explicitly to event traces Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 2/6] cxl/events: Promote CXL event structures to a core header Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 3/6] cxl/events: Separate UUID from event structures Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 4/6] cxl/events: Create a CXL event union Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events Ira Weiny
2023-11-28 20:32 ` Smita Koralahalli
2023-11-29 14:28 ` Ira Weiny
2023-12-13 17:13 ` Jonathan Cameron
2023-12-13 22:28 ` Ira Weiny
2023-12-19 17:12 ` Jonathan Cameron
2023-12-20 23:48 ` Ira Weiny
2024-01-03 17:50 ` Jonathan Cameron
2024-01-03 20:40 ` Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 6/6] cxl/memdev: Register for and process CPER events Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601-cxl-cper-v4-0-47bb901f135e@intel.com \
--to=ira.weiny@intel.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).