From: Kees Cook <keescook@chromium.org>
To: ardb@kernel.org, linux-efi@vger.kernel.org,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Kees Cook <keescook@chromium.org>,
tony.luck@intel.com, linux-hardening@vger.kernel.org,
kernel@gpiccoli.net, kernel-dev@igalia.com
Subject: Re: [PATCH] efi: pstore: Allow dynamic initialization based on module parameter
Date: Thu, 1 Feb 2024 10:01:46 -0800 [thread overview]
Message-ID: <170681050420.3736595.3520971124875660694.b4-ty@chromium.org> (raw)
In-Reply-To: <20240103184053.226203-1-gpiccoli@igalia.com>
On Wed, 03 Jan 2024 15:40:32 -0300, Guilherme G. Piccoli wrote:
> The efi-pstore module parameter "pstore_disable" warrants that users
> are able to deactivate such backend. There is also a Kconfig option
> for the default value of this parameter. It was originally added due
> to some bad UEFI FW implementations that could break with many variables
> written.
>
> Some distros (such as Arch Linux) set this in their config file still
> nowadays. And once it is set, even being a writable module parameter,
> there is effectively no way to make use of efi-pstore anymore.
> If "pstore_disable" is set to true, the init function of the module exits
> early and is never called again after the initcall processing.
>
> [...]
Applied to for-next/pstore, thanks!
[1/1] efi: pstore: Allow dynamic initialization based on module parameter
https://git.kernel.org/kees/c/c3f849caf81b
Take care,
--
Kees Cook
prev parent reply other threads:[~2024-02-01 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 18:40 [PATCH] efi: pstore: Allow dynamic initialization based on module parameter Guilherme G. Piccoli
2024-01-15 21:20 ` Guilherme G. Piccoli
2024-01-16 8:46 ` Greg KH
2024-01-16 11:29 ` Guilherme G. Piccoli
2024-02-01 18:01 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170681050420.3736595.3520971124875660694.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).