From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Ard Biesheuvel <ardb+git@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Kuppuswamy Sathyanarayanan,"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-efi@vger.kernel.org
Subject: [Bug Report] Bug in "efi/libstub: Add get_event_log() support for CC platforms"
Date: Thu, 7 Mar 2024 16:03:14 +0500 [thread overview]
Message-ID: <0229a87e-fb19-4dad-99fc-4afd7ed4099a@collabora.com> (raw)
Hi,
The recent patch:
276805fb9c305: efi/libstub: Add get_event_log() support for CC platforms
has introduced
#define EFI_CC_EVENT_LOG_FORMAT_TCG_2 0x00000002
But EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 has the same numerical value:
#define EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 0x2
Thus there is dead code in efi_retrieve_tcg2_eventlog() i.e, multiple if
conditions with (version == 2) I'm unable to decide on what is wrong and
what is right here. Please have a look.
--
BR,
Muhammad Usama Anjum
next reply other threads:[~2024-03-07 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 11:03 Muhammad Usama Anjum [this message]
2024-03-07 11:08 ` [Bug Report] Bug in "efi/libstub: Add get_event_log() support for CC platforms" Ard Biesheuvel
2024-03-07 11:13 ` Ard Biesheuvel
2024-03-07 11:30 ` Ard Biesheuvel
2024-03-07 15:36 ` Kuppuswamy Sathyanarayanan
2024-03-07 15:41 ` Ard Biesheuvel
2024-03-07 16:21 ` Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0229a87e-fb19-4dad-99fc-4afd7ed4099a@collabora.com \
--to=usama.anjum@collabora.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).