From: "Luck, Tony" <tony.luck@intel.com>
To: "Li, Zhiquan1" <zhiquan1.li@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>,
"mingo@kernel.org" <mingo@kernel.org>,
"naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>
Subject: RE: [PATCH v3] x86/mce: Set PG_hwpoison page flag to avoid the capture kernel panic
Date: Tue, 17 Oct 2023 17:35:02 +0000 [thread overview]
Message-ID: <SJ1PR11MB60830F499CB509A1262C745BFCD6A@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5398da4c-5286-4e1b-924c-6df91f932427@intel.com>
> Tony, your commit message made me realize how verbose my commit message
> is. May I simplify the whole commit message as following for next version?
>
> ---start---
> Memory errors don't happen very often, especially the severity is fatal.
> However, in large-scale scenarios, such as data centers, it might still
> happen. When there is a fatal machine check Linux calls mce_panic()
> without checking to see if bad data at some memory address
> was reported in the machine check banks.
>
> If kexec is enabled, check for memory errors and mark the page as
> poisoned so that the kexec'ed kernel can avoid accessing the page.
> ---end---
>
> It already covers the scenario, root cause and solution, and focuses on
> kernel. No need to talk something else.
Yes, you can use that. Being concise (but keeping the important details)
is the art of a good commit message.
-Tony
prev parent reply other threads:[~2023-10-17 17:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 5:17 [PATCH v3] x86/mce: Set PG_hwpoison page flag to avoid the capture kernel panic Zhiquan Li
2023-10-14 5:12 ` Luck, Tony
2023-10-14 9:34 ` Zhiquan Li
2023-10-14 10:18 ` Borislav Petkov
2023-10-17 1:39 ` Zhiquan Li
2023-10-16 9:11 ` Borislav Petkov
2023-10-17 1:05 ` Zhiquan Li
2023-10-17 1:24 ` Luck, Tony
2023-10-17 11:18 ` Borislav Petkov
2023-10-17 15:00 ` Zhiquan Li
2023-10-17 17:35 ` Luck, Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB60830F499CB509A1262C745BFCD6A@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=patches@lists.linux.dev \
--cc=x86@kernel.org \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).