From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: yazen.ghannam@amd.com, tony.luck@intel.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
avadhut.naik@amd.com, john.allen@amd.com, muralidhara.mk@amd.com
Subject: Re: [PATCH] RAS/AMD/ATL: Add MI300 DRAM to Normalized address translation support
Date: Thu, 1 Feb 2024 16:59:06 -0500 [thread overview]
Message-ID: <20e550af-23b7-4583-af91-0bba4c9529f1@amd.com> (raw)
In-Reply-To: <20240201150543.GHZbuzR4_KJHbCTI1H@fat_crate.local>
On 2/1/2024 10:05 AM, Borislav Petkov wrote:
> On Thu, Feb 01, 2024 at 09:35:13AM -0500, Yazen Ghannam wrote:
>> It's an operation on the bits within a value rather than between two values.
>>
>> BTW, I looked up "internal" in a thesaurus, and nothing seemed much better to me.
>>
>> Maybe something like "xor_bits_in_value()"? This has the verb-first style too.
>
> Ah, ok, easy:
>
> ---
> diff --git a/drivers/ras/amd/atl/umc.c b/drivers/ras/amd/atl/umc.c
> index 67dc186a1226..7e310d1dfcfc 100644
> --- a/drivers/ras/amd/atl/umc.c
> +++ b/drivers/ras/amd/atl/umc.c
> @@ -49,7 +49,8 @@ static u8 get_coh_st_inst_id_mi300(struct atl_err *err)
> return i;
> }
>
> -static u16 internal_bitwise_xor(u16 val)
> +/* XOR the bits in @val. */
> +static u16 bitwise_xor_bits(u16 val)
> {
> u16 tmp = 0;
> u8 i;
> @@ -181,8 +182,8 @@ static unsigned long convert_dram_to_norm_addr_mi300(unsigned long addr)
> if (!addr_hash.bank[i].xor_enable)
> continue;
>
> - temp = internal_bitwise_xor(col & addr_hash.bank[i].col_xor);
> - temp ^= internal_bitwise_xor(row & addr_hash.bank[i].row_xor);
> + temp = bitwise_xor_bits(col & addr_hash.bank[i].col_xor);
> + temp ^= bitwise_xor_bits(row & addr_hash.bank[i].row_xor);
> bank ^= temp << i;
> }
>
> @@ -191,9 +192,9 @@ static unsigned long convert_dram_to_norm_addr_mi300(unsigned long addr)
> /* Bits SID[1:0] act as Bank[6:5] for PC hash, so apply them here. */
> bank |= sid << 5;
>
> - temp = internal_bitwise_xor(col & addr_hash.pc.col_xor);
> - temp ^= internal_bitwise_xor(row & addr_hash.pc.row_xor);
> - temp ^= internal_bitwise_xor(bank & addr_hash.bank_xor);
> + temp = bitwise_xor_bits(col & addr_hash.pc.col_xor);
> + temp ^= bitwise_xor_bits(row & addr_hash.pc.row_xor);
> + temp ^= bitwise_xor_bits(bank & addr_hash.bank_xor);
> pc ^= temp;
>
> /* Drop SID bits for the sake of debug printing later. */
>
>
Yep, easy :) Looks good to me.
Thanks,
Yazen
prev parent reply other threads:[~2024-02-01 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 16:57 [PATCH] RAS/AMD/ATL: Add MI300 DRAM to Normalized address translation support Yazen Ghannam
2024-02-01 7:03 ` M K, Muralidhara
2024-02-01 9:21 ` Borislav Petkov
2024-02-01 14:35 ` Yazen Ghannam
2024-02-01 15:05 ` Borislav Petkov
2024-02-01 21:59 ` Yazen Ghannam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e550af-23b7-4583-af91-0bba4c9529f1@amd.com \
--to=yazen.ghannam@amd.com \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).