From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: tony.luck@intel.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
john.allen@amd.com,
"anthony s . knowles" <akira.2020@protonmail.com>
Subject: Re: [PATCH] RAS: Avoid build errors when CONFIG_DEBUG_FS=n
Date: Wed, 27 Mar 2024 16:48:28 +0100 [thread overview]
Message-ID: <20240327154828.GAZgQ_zK1iUbWxuXd0@fat_crate.local> (raw)
In-Reply-To: <20240326203252.2699278-1-yazen.ghannam@amd.com>
On Tue, Mar 26, 2024 at 08:32:52PM +0000, Yazen Ghannam wrote:
> A new helper was introduced for RAS modules to get be able to get the
> RAS subsystem debugfs root directory. The helper is defined in debugfs.c
> which is only built when CONFIG_DEBUG_FS=y.
>
> However, it's possible that the modules would include debugfs support
> for optional functionality. One current example is the fmpm module. In
> this case, a build error will occur when CONFIG_RAS_FMPM is selected and
> CONFIG_DEBUG_FS=n.
>
> Add an inline helper function stub for the CONFIG_DEBUG_FS=n case.
>
> Fixes: 9d2b6fa09d15 ("RAS: Export helper to get ras_debugfs_dir")
> Reported-by: anthony s. knowles <akira.2020@protonmail.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218640
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Tested-by: anthony s. knowles <akira.2020@protonmail.com>
> Link: https://lore.kernel.org/r/20240325183755.776-1-bp@alien8.de
> ---
> drivers/ras/debugfs.h | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2024-03-27 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 20:32 [PATCH] RAS: Avoid build errors when CONFIG_DEBUG_FS=n Yazen Ghannam
2024-03-27 15:48 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327154828.GAZgQ_zK1iUbWxuXd0@fat_crate.local \
--to=bp@alien8.de \
--cc=akira.2020@protonmail.com \
--cc=avadhut.naik@amd.com \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).