From: Borislav Petkov <bp@alien8.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
muralidhara.mk@amd.com, linux-edac@vger.kernel.org
Subject: Re: [bug report] RAS/AMD/ATL: Add MI300 support
Date: Wed, 31 Jan 2024 19:50:49 +0100 [thread overview]
Message-ID: <20240131185049.GKZbqWiUVLWXI7-TQY@fat_crate.local> (raw)
In-Reply-To: <3d20cb1e-e116-416a-ac1b-3e4226c85e74@moroto.mountain>
On Wed, Jan 31, 2024 at 09:33:13PM +0300, Dan Carpenter wrote:
> Oh, sorry, I hadn't seen that test_bit was also declared as bool.
> This is a bug in Smatch. I will fix it.
We're glad that we were able to contribute to improving Smatch! :-)
> No, only bool can only be true/false (BIT(0)).
That is not specified by the standard. If a bool is true, it doesn't
necessarily mean that bit 0 of that bool storage area is 1b. I.e.,
0b0000_0001.
BUT, when it takes part in integer expressions, it will be
type-converted to 1 and thus work as expected.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2024-01-31 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:24 [bug report] RAS/AMD/ATL: Add MI300 support Dan Carpenter
2024-01-31 8:56 ` Borislav Petkov
2024-01-31 15:45 ` Yazen Ghannam
2024-01-31 16:11 ` Borislav Petkov
2024-01-31 18:33 ` Dan Carpenter
2024-01-31 18:50 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131185049.GKZbqWiUVLWXI7-TQY@fat_crate.local \
--to=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).