From: Borislav Petkov <bp@alien8.de>
To: Zhiquan Li <zhiquan1.li@intel.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>, linux-edac@vger.kernel.org
Subject: Re: [bug report] x86/mce: Mark fatal MCE's page as poison to avoid panic in the kdump kernel
Date: Wed, 25 Oct 2023 09:48:04 +0200 [thread overview]
Message-ID: <20231025074804.GBZTjINPXkFlpfgwV8@fat_crate.local> (raw)
In-Reply-To: <fe7d6f43-2a10-4c73-be5b-d0702d0d89c8@intel.com>
On Wed, Oct 25, 2023 at 02:19:26PM +0800, Zhiquan Li wrote:
> + if (final && (final->status & MCI_STATUS_ADDRV))
> + p = pfn_to_online_page(final->addr >> PAGE_SHIFT);
> + if (p)
> + SetPageHWPoison(p);
>
> The assignment can not be put into the "if" condition, checkpatch.pl script
> will complain it.
It doesn't complain here:
$ git diff | ./scripts/checkpatch.pl
total: 0 errors, 0 warnings, 14 lines checked
Your patch has no obvious style problems and is ready for submission
> I'll re-validate the patch and send V5 soon.
When you do, please send it with my edits to the text.
Zapped from tip for now.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-10-25 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 5:44 [bug report] x86/mce: Mark fatal MCE's page as poison to avoid panic in the kdump kernel Dan Carpenter
2023-10-25 6:19 ` Zhiquan Li
2023-10-25 7:48 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025074804.GBZTjINPXkFlpfgwV8@fat_crate.local \
--to=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).