From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
linux-edac@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH 08/21] EDAC/highbank_l2: Convert to platform remove callback returning void
Date: Wed, 4 Oct 2023 15:12:41 +0200 [thread overview]
Message-ID: <20231004131254.2673842-9-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20231004131254.2673842-1-u.kleine-koenig@pengutronix.de>
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/edac/highbank_l2_edac.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/highbank_l2_edac.c b/drivers/edac/highbank_l2_edac.c
index 140d4431bd0d..5646c049a934 100644
--- a/drivers/edac/highbank_l2_edac.c
+++ b/drivers/edac/highbank_l2_edac.c
@@ -118,18 +118,17 @@ static int highbank_l2_err_probe(struct platform_device *pdev)
return res;
}
-static int highbank_l2_err_remove(struct platform_device *pdev)
+static void highbank_l2_err_remove(struct platform_device *pdev)
{
struct edac_device_ctl_info *dci = platform_get_drvdata(pdev);
edac_device_del_device(&pdev->dev);
edac_device_free_ctl_info(dci);
- return 0;
}
static struct platform_driver highbank_l2_edac_driver = {
.probe = highbank_l2_err_probe,
- .remove = highbank_l2_err_remove,
+ .remove_new = highbank_l2_err_remove,
.driver = {
.name = "hb_l2_edac",
.of_match_table = hb_l2_err_of_match,
--
2.40.1
next prev parent reply other threads:[~2023-10-04 13:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 01/21] EDAC/altera: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 02/21] EDAC/armada_xp: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 03/21] EDAC/aspeed: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 04/21] EDAC/bluefield: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 05/21] EDAC/cell: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 06/21] EDAC/cpc925: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 07/21] EDAC/dmc520: " Uwe Kleine-König
2023-10-04 13:12 ` Uwe Kleine-König [this message]
2023-11-20 17:45 ` [PATCH 08/21] EDAC/highbank_l2: " Andre Przywara
2023-10-04 13:12 ` [PATCH 09/21] EDAC/highbank_mc: " Uwe Kleine-König
2023-11-20 17:45 ` Andre Przywara
2023-10-04 13:12 ` [PATCH 10/21] EDAC/mpc85xx: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 11/21] EDAC/npcm: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 12/21] EDAC/octeon-l2c: " Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 13/21] EDAC/octeon-lmc: " Uwe Kleine-König
2023-10-10 14:02 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 14/21] EDAC/octeon-pc: " Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 15/21] EDAC/octeon-pci: " Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 16/21] EDAC/ppc4xx: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 17/21] EDAC/qcom: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 18/21] EDAC/synopsys: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 19/21] EDAC/ti: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 20/21] EDAC/xgene: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 21/21] EDAC/zynqmp: " Uwe Kleine-König
2023-10-04 13:14 ` Michal Simek
2023-10-13 10:04 ` [PATCH 22/21] EDAC/fsl_ddr: " Uwe Kleine-König
2023-11-20 16:20 ` [PATCH 00/21] EDAC: " Uwe Kleine-König
2023-11-20 17:21 ` Borislav Petkov
2023-11-20 22:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004131254.2673842-9-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andre.przywara@arm.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel@pengutronix.de \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).