From: <ankita@nvidia.com>
To: <ankita@nvidia.com>, <jgg@nvidia.com>,
<alex.williamson@redhat.com>, <akpm@linux-foundation.org>,
<tony.luck@intel.com>, <bp@alien8.de>, <naoya.horiguchi@nec.com>,
<linmiaohe@huawei.com>
Cc: <aniketa@nvidia.com>, <cjia@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <vsethi@nvidia.com>, <acurrid@nvidia.com>,
<anuaggarwal@nvidia.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-edac@vger.kernel.org>,
<kvm@vger.kernel.org>
Subject: [PATCH v1 0/4] mm: Implement ECC handling for pfn with no struct page
Date: Wed, 20 Sep 2023 19:32:06 +0530 [thread overview]
Message-ID: <20230920140210.12663-1-ankita@nvidia.com> (raw)
From: Ankit Agrawal <ankita@nvidia.com>
The kernel MM currently handles ECC errors / poison only on memory page
backed by struct page. As part of [1], the nvgrace-gpu-vfio-pci module
maps the device memory to user VA (Qemu) using remap_pfn_range without
being added to the kernel. These pages are not backed by struct page.
Implement a new ECC handling for memory without struct pages. Kernel MM
expose registration APIs to allow modules that are managing the device
to register its memory region and a callback function. MM then tracks
such regions using interval tree.
The mechanism is largely similar to that of ECC on pfn with struct pages.
If there is an ECC error on a pfn, MM uses the registered memory failure
callback function to notify the module of the faulty PFN, so that the
module may take any required action. The pfn is then unmapped in Stage-2.
When the VM tries to access the page, it gets trapped in KVM, which calls
the vm ops fault function. If the module fault function returns
VM_FAULT_HWPOISON, KVM sends a BUS_MCEERR_AR to the usermode (Qemu) mapped
to the poisoned page.
Lastly, nvgrace-gpu-vfio-pci module make use of the new mechanism to get
poison handling support on the device memory.
Patch generated over v6.6-rc2 and with [1] applied. [1] is currently under
review.
[1] https://lore.kernel.org/all/20230915025415.6762-1-ankita@nvidia.com/
Ankit Agrawal (4):
mm: handle poisoning of pfn without struct pages
mm: Add poison error check in fixup_user_fault() for mapped pfn
mm: Change ghes code to allow poison of non-struct pfn
vfio/nvgpu: register device memory for poison handling
drivers/acpi/apei/ghes.c | 12 +--
drivers/vfio/pci/nvgrace-gpu/main.c | 107 +++++++++++++++++++++-
drivers/vfio/vfio.h | 11 ---
drivers/vfio/vfio_main.c | 3 +-
include/linux/memory-failure.h | 22 +++++
include/linux/mm.h | 1 +
include/linux/vfio.h | 15 ++++
include/ras/ras_event.h | 1 +
mm/Kconfig | 1 +
mm/gup.c | 2 +-
mm/memory-failure.c | 135 +++++++++++++++++++++++-----
virt/kvm/kvm_main.c | 6 ++
12 files changed, 270 insertions(+), 46 deletions(-)
create mode 100644 include/linux/memory-failure.h
--
2.17.1
next reply other threads:[~2023-09-20 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 14:02 ankita [this message]
2023-09-20 14:02 ` [PATCH v1 1/4] mm: handle poisoning of pfn without struct pages ankita
2023-09-23 3:20 ` Miaohe Lin
2023-09-25 12:36 ` Jason Gunthorpe
2023-09-26 7:23 ` Naoya Horiguchi
2023-09-20 14:02 ` [PATCH v1 2/4] mm: Add poison error check in fixup_user_fault() for mapped pfn ankita
2023-09-20 14:02 ` [PATCH v1 3/4] mm: Change ghes code to allow poison of non-struct pfn ankita
2023-09-20 14:02 ` [PATCH v1 4/4] vfio/nvgpu: register device memory for poison handling ankita
2023-09-26 5:36 ` kernel test robot
2023-09-26 7:38 ` Naoya Horiguchi
2023-09-28 19:45 ` Alex Williamson
2023-09-20 16:02 ` [PATCH v1 0/4] mm: Implement ECC handling for pfn with no struct page Andrew Morton
2023-09-20 16:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920140210.12663-1-ankita@nvidia.com \
--to=ankita@nvidia.com \
--cc=acurrid@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=aniketa@nvidia.com \
--cc=anuaggarwal@nvidia.com \
--cc=bp@alien8.de \
--cc=cjia@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linmiaohe@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=targupta@nvidia.com \
--cc=tony.luck@intel.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).