From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Danielle Ratson <danieller@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"sdf@google.com" <sdf@google.com>,
"kory.maincent@bootlin.com" <kory.maincent@bootlin.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"przemyslaw.kitszel@intel.com" <przemyslaw.kitszel@intel.com>,
"ahmed.zaki@intel.com" <ahmed.zaki@intel.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"shayagr@amazon.com" <shayagr@amazon.com>,
"paul.greenwalt@intel.com" <paul.greenwalt@intel.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
mlxsw <mlxsw@nvidia.com>, Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH net-next v5 04/10] ethtool: Add flashing transceiver modules' firmware notifications ability
Date: Wed, 1 May 2024 07:37:58 -0700 [thread overview]
Message-ID: <20240501073758.3da76601@kernel.org> (raw)
In-Reply-To: <ZjH1DCu0rJTL_RYz@shredder>
On Wed, 1 May 2024 10:53:48 +0300 Ido Schimmel wrote:
> We can try to use unicast, but the current design is influenced by
> devlink firmware flash (see __devlink_flash_update_notify()) and ethtool
> cable testing (see ethnl_cable_test_started() and
> ethnl_cable_test_finished()), both of which use multicast notifications
> although the latter does not update about progress.
>
> Do you want us to try the unicast approach or be consistent with the
> above examples?
We are charting a bit of a new territory here, you're right that
the precedents point in the direction of multicast.
The unicast is harder to get done on the kernel side (we should
probably also check that the socket pid didn't get reused, stop
sending the notifications when original socket gets closed?)
It will require using pretty much all the pieces of advanced
netlink infra we have, I'm happy to explain more, but I'll also
understand if you prefer to stick to multicast.
next prev parent reply other threads:[~2024-05-01 14:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:30 [PATCH net-next v5 00/10] Add ability to flash modules' firmware Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 01/10] ethtool: Add ethtool operation to write to a transceiver module EEPROM Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 02/10] mlxsw: Implement " Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 03/10] ethtool: Add an interface for flashing transceiver modules' firmware Danielle Ratson
2024-04-30 2:14 ` Jakub Kicinski
2024-04-24 13:30 ` [PATCH net-next v5 04/10] ethtool: Add flashing transceiver modules' firmware notifications ability Danielle Ratson
2024-04-30 3:11 ` Jakub Kicinski
2024-04-30 18:11 ` Danielle Ratson
2024-04-30 20:03 ` Jakub Kicinski
2024-05-01 7:53 ` Ido Schimmel
2024-05-01 14:37 ` Jakub Kicinski [this message]
2024-05-22 13:08 ` Danielle Ratson
2024-05-22 13:45 ` Jakub Kicinski
2024-05-22 13:56 ` Danielle Ratson
2024-05-22 14:22 ` Jakub Kicinski
2024-05-27 16:10 ` Ido Schimmel
2024-05-27 16:30 ` Jakub Kicinski
2024-04-24 13:30 ` [PATCH net-next v5 05/10] include: netdevice: Add module firmware flashing in progress flag to net_device Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 06/10] net: sfp: Add more extended compliance codes Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 08/10] ethtool: cmis_fw_update: add a layer for supporting firmware update using CDB Danielle Ratson
2024-04-24 13:30 ` [PATCH net-next v5 09/10] ethtool: Add ability to flash transceiver modules' firmware Danielle Ratson
2024-04-30 3:22 ` Jakub Kicinski
2024-04-24 13:30 ` [PATCH net-next v5 10/10] ethtool: Veto some operations during firmware flashing process Danielle Ratson
2024-04-30 3:23 ` Jakub Kicinski
2024-04-30 17:48 ` Danielle Ratson
2024-04-30 18:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501073758.3da76601@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sdf@google.com \
--cc=shayagr@amazon.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).