From: MD Danish Anwar <danishanwar@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<srk@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
<r-gunasekaran@ti.com>, Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH net-next] dt-bindings: net: ti: icssg_prueth: Add documentation for PA_STATS support
Date: Tue, 14 May 2024 11:18:33 +0530 [thread overview]
Message-ID: <f0586fff-c47a-4610-bb31-5a5ad743a1be@ti.com> (raw)
In-Reply-To: <8ce66e56-7f41-4f2d-ac10-1328784a51af@kernel.org>
Hi Krzysztof,
On 01/05/24 3:56 pm, Krzysztof Kozlowski wrote:
> On 30/04/2024 14:24, MD Danish Anwar wrote:
>> Add documentation for ti,pa-stats property which is syscon regmap for
>> PA_STATS register. This will be used to dump statistics maintained by
>> ICSSG firmware.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>> Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index e253fa786092..abf372f7191b 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -55,6 +55,11 @@ properties:
>> description:
>> phandle to MII_RT module's syscon regmap
>>
>> + ti,pa-stats:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to PA_STATS module's syscon regmap
>
> One register needed? Then use phandle-array syntax - see examples.
No this is not one register only. PA_STATS is a set of registers. My bad
I should have mentioned *registers* in the commit description. Just like
MII_RT and MII_G_RT modules, PA_STATS is also a set of registers where
different statistics are dumped by ICSSG firmware. Moduling this as
syscon will help the driver read/write those statistics using
regmap_read() / write() just like the driver currently read / write
registers from mii_rt and mii_g_rt regmaps.
I have tried to describe this node *ti,pa-stats* the same way as
"ti,mii-g-rt" and "ti,mii-rt"
> Explain in description the purpose of this register in the context of
> *this* device.
>
Sure will do that.
> Best regards,
> Krzysztof
>
--
Thanks and Regards,
Danish
prev parent reply other threads:[~2024-05-14 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:24 [PATCH net-next] dt-bindings: net: ti: icssg_prueth: Add documentation for PA_STATS support MD Danish Anwar
2024-05-01 10:26 ` Krzysztof Kozlowski
2024-05-14 5:48 ` MD Danish Anwar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0586fff-c47a-4610-bb31-5a5ad743a1be@ti.com \
--to=danishanwar@ti.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).