From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arthur Becker <arthur.becker@sentec.com>,
Jonathan Cameron <jic23@kernel.org>,
"robh@kernel.org" <robh@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: light: add veml6040 RGBW-LS bindings
Date: Tue, 14 May 2024 09:11:09 +0200 [thread overview]
Message-ID: <b86470c8-94fe-4a44-a7db-7f2dcff7d7ac@kernel.org> (raw)
In-Reply-To: <2f23c0ae-8f8d-41db-af6c-c1b82e965466@kernel.org>
On 14/05/2024 09:10, Krzysztof Kozlowski wrote:
> On 13/05/2024 16:35, Arthur Becker wrote:
>> This commit adds device tree bindings for the veml6040 RGBW Light Sensor
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> More importantly: where is the driver or any other user of this binding?
> Why this is sent alone?
Also:
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-05-14 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 14:35 [PATCH] dt-bindings: iio: light: add veml6040 RGBW-LS bindings Arthur Becker
2024-05-13 16:26 ` Conor Dooley
2024-05-19 11:57 ` Jonathan Cameron
2024-05-19 12:02 ` Conor Dooley
2024-05-19 12:25 ` Jonathan Cameron
2024-05-14 7:10 ` Krzysztof Kozlowski
2024-05-14 7:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b86470c8-94fe-4a44-a7db-7f2dcff7d7ac@kernel.org \
--to=krzk@kernel.org \
--cc=arthur.becker@sentec.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).