From: Eddie James <eajames@linux.ibm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-fsi@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au
Subject: Re: [PATCH v5 5/9] dt-bindings: fsi: Document the FSI controller common properties
Date: Wed, 15 May 2024 10:02:46 -0500 [thread overview]
Message-ID: <80713a00-9574-4ae0-8af7-3fe12affcfc1@linux.ibm.com> (raw)
In-Reply-To: <eb6e2b5b-f341-404b-9215-6e80f21a6842@kernel.org>
On 5/15/24 09:35, Krzysztof Kozlowski wrote:
> On 15/05/2024 16:28, Eddie James wrote:
>> On 5/15/24 09:18, Krzysztof Kozlowski wrote:
>>> On 14/05/2024 21:54, Eddie James wrote:
>>>> Since there are multiple FSI controllers documented, the common
>>>> properties should be documented separately and then referenced
>>>> from the specific controller documentation.
>>>>
>>>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>>>> ---
>>>> Changes since v4:
>>>> - Add interrupt controller properties
>>>> - Add clock-frequency property to FSI controller and CFAM
>>>> - Add detail to chip-id property description
>>>>
>>>> .../bindings/fsi/fsi-controller.yaml | 66 +++++++++++++++++++
>>>> 1 file changed, 66 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/fsi/fsi-controller.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/fsi/fsi-controller.yaml b/Documentation/devicetree/bindings/fsi/fsi-controller.yaml
>>>> new file mode 100644
>>>> index 0000000000000..8620e4da6de77
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/fsi/fsi-controller.yaml
>>>> @@ -0,0 +1,66 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/fsi/fsi-controller.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: FSI Controller Common Properties
>>>> +
>>>> +maintainers:
>>>> + - Eddie James <eajames@linux.ibm.com>
>>>> +
>>>> +description:
>>>> + FSI (FRU (Field Replaceable Unit) Service Interface) is a two wire bus. The
>>>> + FSI bus is connected to a CFAM (Common FRU Access Macro) which contains
>>>> + various engines such as I2C controllers, SPI controllers, etc.
>>>> +
>>>> +properties:
>>>> + "#address-cells":
>>>> + const: 2
>>>> +
>>>> + "#size-cells":
>>>> + const: 0
>>>> +
>>>> + '#interrupt-cells':
>>>> + const: 1
>>>> +
>>>> + clock-frequency:
>>>> + minimum: 1
>>>> + maximum: 200000000
>>> This is a deprecated property in general. Why did it appear? It does not
>>> exist in current bindings and nothing in commit msg suggests changes in
>>> the bindings themselves.
>>
>> OK, is there some document that describes what properties are
>> deprecated? Because it's used all over the place in the bindings. Anyway
> dtschema: dtschema/schemas/clock/clock.yaml
>
> buses anyway should use bus-frequency but it is also legacy one.
>
>> I need this property, I can rename it if you like. I can also update the
> Why do you need it? Why clocks cannot be chosen by drivers and initial
> state selected by assigned-clock-rates?
Well, I could use assigned-clock-rates, though it seems like I'd then
have to implement the clock provider framework for both the FSI
controller driver and the CFAM driver, which is a lot of extra work. FSI
controller isn't really a clock provider, it's a bus like i2c (which
uses clock-frequency), so it doesn't quite fit in my opinion...
Thanks for your detailed review Krzysztof,
Eddie
>
>
>> commit message to indicate that I'm adding it.
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-05-15 15:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 19:54 [PATCH v5 0/9] dt-bindings: fsi: Convert to json-schema and add missing engines Eddie James
2024-05-14 19:54 ` [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-05-14 22:35 ` Rob Herring (Arm)
2024-05-15 8:14 ` Krzysztof Kozlowski
2024-05-15 13:06 ` Eddie James
2024-05-15 14:12 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 2/9] dt-bindings: fsi: Document the IBM SCOM engine Eddie James
2024-05-14 19:54 ` [PATCH v5 3/9] dt-bindings: fsi: p9-occ: Convert to json-schema Eddie James
2024-05-15 8:14 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 4/9] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-05-14 19:54 ` [PATCH v5 5/9] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-05-15 14:18 ` Krzysztof Kozlowski
2024-05-15 14:28 ` Eddie James
2024-05-15 14:35 ` Krzysztof Kozlowski
2024-05-15 15:02 ` Eddie James [this message]
2024-05-17 9:17 ` Krzysztof Kozlowski
2024-05-22 14:39 ` Rob Herring
2024-05-14 19:54 ` [PATCH v5 6/9] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-05-14 19:54 ` [PATCH v5 7/9] dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema Eddie James
2024-05-15 14:21 ` Krzysztof Kozlowski
2024-05-15 14:24 ` Eddie James
2024-05-15 14:29 ` Krzysztof Kozlowski
2024-05-15 14:29 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 8/9] dt-bindings: fsi: Document the AST2700 FSI master Eddie James
2024-05-15 14:21 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 9/9] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80713a00-9574-4ae0-8af7-3fe12affcfc1@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).