From: Naina Mehta <quic_nainmeht@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <ulf.hansson@linaro.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<bhupesh.sharma@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdx75-idp: add SDHCI for SD Card
Date: Thu, 16 May 2024 10:51:22 +0530 [thread overview]
Message-ID: <2ed5326a-b2ea-220a-2a9b-0478df0c6f12@quicinc.com> (raw)
In-Reply-To: <a5833628-65f3-493d-9de5-33ba87a18875@kernel.org>
On 5/15/2024 7:53 PM, Krzysztof Kozlowski wrote:
> On 15/05/2024 14:09, Naina Mehta wrote:
>> Enable SDHCI on sdx75-idp to support SD card.
>> Also add the required regulators.
>>
>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sdx75-idp.dts | 45 ++++++++++++++++++++++++++
>> 1 file changed, 45 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>> index f76e72fb2072..6f94278cf837 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>> @@ -41,6 +41,29 @@
>>
>> vin-supply = <&vph_ext>;
>> };
>> +
>> + vreg_sd_vccb: sd-vccb {
>
> Please use name for all fixed regulators which matches current format
> recommendation: 'regulator-[0-9]+v[0-9]+'
Did you mean that vreg_sd_vdd should be updated according to the
suggested format because vreg_sd_vccb is not a fixed regulator?
Thanks,
Naina
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?id=b6d4b3500d57370f5b3abf0701c9166b384db976
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-05-16 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 12:09 [PATCH 0/3] Add SDHCI support for SDX75 SoC Naina Mehta
2024-05-15 12:09 ` [PATCH 1/3] dt-bindings: mmc: sdhci-msm: Document the SDX75 compatible Naina Mehta
2024-05-15 14:22 ` Krzysztof Kozlowski
2024-05-15 12:09 ` [PATCH 2/3] arm64: dts: qcom: sdx75: Add SDHCI node Naina Mehta
2024-05-15 12:09 ` [PATCH 3/3] arm64: dts: qcom: sdx75-idp: add SDHCI for SD Card Naina Mehta
2024-05-15 14:23 ` Krzysztof Kozlowski
2024-05-16 5:21 ` Naina Mehta [this message]
2024-05-17 8:52 ` Krzysztof Kozlowski
2024-05-17 11:09 ` Naina Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed5326a-b2ea-220a-2a9b-0478df0c6f12@quicinc.com \
--to=quic_nainmeht@quicinc.com \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).