* [PATCH 0/3] Mediatek MT8195 power domain support
@ 2021-06-10 2:36 Chun-Jie Chen
[not found] ` <20210610023614.5375-4-chun-jie.chen@mediatek.com>
0 siblings, 1 reply; 2+ messages in thread
From: Chun-Jie Chen @ 2021-06-10 2:36 UTC (permalink / raw
To: Enric Balletbo i Serra, Matthias Brugger, Nicolas Boichat,
Rob Herring
Cc: linux-arm-kernel, linux-kernel, devicetree, linux-mediatek,
srv_heupstream, Project_Global_Chrome_Upstream_Group
This patch series adds power domain support for MT8195
and is based on 5.13-rc3.
chun-jie.chen (3):
soc: mediatek: pm-domains: Move power status offset to power domain
data
dt-bindings: power: Add MT8195 power domains
soc: mediatek: pm-domains: Add support for mt8195
.../power/mediatek,power-controller.yaml | 2 +
drivers/soc/mediatek/mt8167-pm-domains.h | 16 +-
drivers/soc/mediatek/mt8173-pm-domains.h | 22 +-
drivers/soc/mediatek/mt8183-pm-domains.h | 32 +-
drivers/soc/mediatek/mt8192-pm-domains.h | 44 +-
drivers/soc/mediatek/mt8195-pm-domains.h | 738 ++++++++++++++++++
drivers/soc/mediatek/mtk-pm-domains.c | 12 +-
drivers/soc/mediatek/mtk-pm-domains.h | 8 +-
include/dt-bindings/power/mt8195-power.h | 51 ++
include/linux/soc/mediatek/infracfg.h | 103 +++
10 files changed, 1013 insertions(+), 15 deletions(-)
create mode 100644 drivers/soc/mediatek/mt8195-pm-domains.h
create mode 100644 include/dt-bindings/power/mt8195-power.h
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] soc: mediatek: pm-domains: Add support for mt8195
[not found] ` <20210610023614.5375-4-chun-jie.chen@mediatek.com>
@ 2021-06-10 8:50 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2021-06-10 8:50 UTC (permalink / raw
To: Chun-Jie Chen, Enric Balletbo i Serra, Nicolas Boichat,
Rob Herring
Cc: linux-arm-kernel, linux-kernel, devicetree, linux-mediatek,
srv_heupstream, Project_Global_Chrome_Upstream_Group,
chun-jie.chen
Hi Chun-Jie,
Thanks for the patch, comments below.
On 10/06/2021 04:36, Chun-Jie Chen wrote:
> From: "chun-jie.chen" <chun-jie.chen@mediatek.corp-partner.google.com>
>
> Add the needed board data to support mt8195 SoC.
>
Please try to come up with a better commit message. Especially mention that we
have to increase the SPM_MAX_BUS_PROT_DATA.
> Signed-off-by: chun-jie.chen <chun-jie.chen@mediatek.com>
I suppose your name would be "Chun-Jie Chen"
Please also fix your git settings to that From and Signed-off-by matches.
[...]
>
> diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h
> index 8b86ed22ca56..1b8967b9829e 100644
> --- a/drivers/soc/mediatek/mtk-pm-domains.h
> +++ b/drivers/soc/mediatek/mtk-pm-domains.h
> @@ -37,7 +37,7 @@
> #define PWR_STATUS_AUDIO BIT(24)
> #define PWR_STATUS_USB BIT(25)
>
> -#define SPM_MAX_BUS_PROT_DATA 5
> +#define SPM_MAX_BUS_PROT_DATA 6
>
> #define _BUS_PROT(_mask, _set, _clr, _sta, _update, _ignore) { \
> .bus_prot_mask = (_mask), \
> @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data {
> bool ignore_clr_ack;
> };
>
> -#define MAX_SUBSYS_CLKS 10
> -
Good catch, not needed define. Can you put that in a new patch please?
Regards,
Matthias
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-10 2:36 [PATCH 0/3] Mediatek MT8195 power domain support Chun-Jie Chen
[not found] ` <20210610023614.5375-4-chun-jie.chen@mediatek.com>
2021-06-10 8:50 ` [PATCH 3/3] soc: mediatek: pm-domains: Add support for mt8195 Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).