From: Liu Ying <victor.liu@nxp.com>
To: Aradhya Bhatia <a-bhatia1@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: DRI Development List <dri-devel@lists.freedesktop.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>, Udit Kumar <u-kumar1@ti.com>,
Devarsh Thakkar <devarsht@ti.com>, Jai Luthra <j-luthra@ti.com>
Subject: Re: [PATCH v3 6/6] drm/panel: simple: Add Microtips Technology MF-103HIEB0GA0 panel
Date: Thu, 16 May 2024 10:33:44 +0800 [thread overview]
Message-ID: <15511740-ceba-42c6-abf5-b74a757a2930@nxp.com> (raw)
In-Reply-To: <20240515095133.745492-7-a-bhatia1@ti.com>
On 5/15/24 17:51, Aradhya Bhatia wrote:
> Add support for Microtips Technology USA MF-103HIEB0GA0 10.25"[0],
> 1920x720, 8-bit TFT LCD with LVDS interface. Its a Dual-LVDS Panel and
> does not support touch.
>
> [0]: Panel Datasheet
> https://simplespec.microtipsusa.com/uploads/spec/datasheetFile/2660/13-103HIEB0GA0-S_V1.0_20211206.pdf
>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
Like my comments for patch 3/6, this panel is not simple enough
for this driver.
Regards,
Liu Ying
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3a0d8f0ff267..1b0a6b4e034c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3084,6 +3084,35 @@ static const struct panel_desc microtips_mf_101hiebcaf0_c = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct drm_display_mode microtips_mf_103hieb0ga0_mode = {
> + .clock = 93301,
> + .hdisplay = 1920,
> + .hsync_start = 1920 + 72,
> + .hsync_end = 1920 + 72 + 72,
> + .htotal = 1920 + 72 + 72 + 72,
> + .vdisplay = 720,
> + .vsync_start = 720 + 3,
> + .vsync_end = 720 + 3 + 3,
> + .vtotal = 720 + 3 + 3 + 2,
> +};
> +
> +static const struct panel_desc microtips_mf_103hieb0ga0 = {
> + .modes = µtips_mf_103hieb0ga0_mode,
> + .bpc = 8,
> + .num_modes = 1,
> + .size = {
> + .width = 244,
> + .height = 92,
> + },
> + .delay = {
> + .prepare = 50,
> + .disable = 50,
> + },
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
> static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> .clock = 30400,
> .hdisplay = 800,
> @@ -4726,6 +4755,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "microtips,mf-101hiebcaf0",
> .data = µtips_mf_101hiebcaf0_c,
> + }, {
> + .compatible = "microtips,mf-103hieb0ga0",
> + .data = µtips_mf_103hieb0ga0,
> }, {
> .compatible = "mitsubishi,aa070mc01-ca1",
> .data = &mitsubishi_aa070mc01,
next prev parent reply other threads:[~2024-05-16 2:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 9:51 [PATCH v3 0/6] drm/panel: simple: Add Panels and Panel Vendors Aradhya Bhatia
2024-05-15 9:51 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add microtips Aradhya Bhatia
2024-05-15 9:51 ` [PATCH v3 2/6] dt-bindings: vendor-prefixes: Add lincolntech Aradhya Bhatia
2024-05-15 9:51 ` [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels Aradhya Bhatia
2024-05-15 14:23 ` Krzysztof Kozlowski
2024-05-16 2:19 ` Liu Ying
2024-05-16 11:06 ` Aradhya Bhatia
2024-05-16 12:36 ` Neil Armstrong
2024-05-17 2:11 ` Liu Ying
2024-05-15 9:51 ` [PATCH v3 4/6] drm/panel: simple: Add Lincoln Tech Sol LCD185-101CT panel Aradhya Bhatia
2024-05-15 21:16 ` Neil Armstrong
2024-05-15 9:51 ` [PATCH v3 5/6] drm/panel: simple: Add Microtips Technology 13-101HIEBCAF0-C panel Aradhya Bhatia
2024-05-15 21:17 ` Neil Armstrong
2024-05-15 9:51 ` [PATCH v3 6/6] drm/panel: simple: Add Microtips Technology MF-103HIEB0GA0 panel Aradhya Bhatia
2024-05-15 21:17 ` Neil Armstrong
2024-05-16 2:33 ` Liu Ying [this message]
2024-05-15 21:22 ` [PATCH v3 0/6] drm/panel: simple: Add Panels and Panel Vendors Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15511740-ceba-42c6-abf5-b74a757a2930@nxp.com \
--to=victor.liu@nxp.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j-luthra@ti.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).