* [PATCH] dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema
@ 2021-05-10 12:10 Geert Uytterhoeven
2021-05-11 19:50 ` Rob Herring
2021-05-14 10:34 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-05-10 12:10 UTC (permalink / raw
To: Rob Herring, Kishon Vijay Abraham I, Vinod Koul, Sergei Shtylyov
Cc: devicetree, linux-phy, linux-renesas-soc, Geert Uytterhoeven
Convert the Renesas R-Car Gen3 PCIe PHY Device Tree binding
documentation to json-schema.
Update the example to match reality.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
I have listed Sergei as the maintainer, as he wrote the original driver
and bindings. Sergei: Please scream if this is inappropriate ;-)
---
.../bindings/phy/rcar-gen3-phy-pcie.txt | 24 ---------
.../phy/renesas,rcar-gen3-pcie-phy.yaml | 53 +++++++++++++++++++
2 files changed, 53 insertions(+), 24 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-pcie.txt
create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen3-pcie-phy.yaml
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-pcie.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-pcie.txt
deleted file mode 100644
index 63853b35e0830d21..0000000000000000
--- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-pcie.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-* Renesas R-Car generation 3 PCIe PHY
-
-This file provides information on what the device node for the R-Car
-generation 3 PCIe PHY contains.
-
-Required properties:
-- compatible: "renesas,r8a77980-pcie-phy" if the device is a part of the
- R8A77980 SoC.
-- reg: offset and length of the register block.
-- clocks: clock phandle and specifier pair.
-- power-domains: power domain phandle and specifier pair.
-- resets: reset phandle and specifier pair.
-- #phy-cells: see phy-bindings.txt in the same directory, must be <0>.
-
-Example (R-Car V3H):
-
- pcie-phy@e65d0000 {
- compatible = "renesas,r8a77980-pcie-phy";
- reg = <0 0xe65d0000 0 0x8000>;
- #phy-cells = <0>;
- clocks = <&cpg CPG_MOD 319>;
- power-domains = <&sysc 32>;
- resets = <&cpg 319>;
- };
diff --git a/Documentation/devicetree/bindings/phy/renesas,rcar-gen3-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,rcar-gen3-pcie-phy.yaml
new file mode 100644
index 0000000000000000..247ef7c47cf5b52b
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/renesas,rcar-gen3-pcie-phy.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/renesas,rcar-gen3-pcie-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Generation 3 PCIe PHY
+
+maintainers:
+ - Sergei Shtylyov <sergei.shtylyov@gmail.com>
+
+properties:
+ compatible:
+ const: renesas,r8a77980-pcie-phy
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+ '#phy-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - power-domains
+ - resets
+ - '#phy-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/r8a77980-cpg-mssr.h>
+ #include <dt-bindings/power/r8a77980-sysc.h>
+
+ pcie-phy@e65d0000 {
+ compatible = "renesas,r8a77980-pcie-phy";
+ reg = <0xe65d0000 0x8000>;
+ #phy-cells = <0>;
+ clocks = <&cpg CPG_MOD 319>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ resets = <&cpg 319>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema
2021-05-10 12:10 [PATCH] dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema Geert Uytterhoeven
@ 2021-05-11 19:50 ` Rob Herring
2021-05-14 10:34 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-11 19:50 UTC (permalink / raw
To: Geert Uytterhoeven
Cc: Rob Herring, devicetree, Vinod Koul, Kishon Vijay Abraham I,
linux-renesas-soc, Sergei Shtylyov, linux-phy
On Mon, 10 May 2021 14:10:40 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas R-Car Gen3 PCIe PHY Device Tree binding
> documentation to json-schema.
>
> Update the example to match reality.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> I have listed Sergei as the maintainer, as he wrote the original driver
> and bindings. Sergei: Please scream if this is inappropriate ;-)
> ---
> .../bindings/phy/rcar-gen3-phy-pcie.txt | 24 ---------
> .../phy/renesas,rcar-gen3-pcie-phy.yaml | 53 +++++++++++++++++++
> 2 files changed, 53 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-pcie.txt
> create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen3-pcie-phy.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema
2021-05-10 12:10 [PATCH] dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema Geert Uytterhoeven
2021-05-11 19:50 ` Rob Herring
@ 2021-05-14 10:34 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-05-14 10:34 UTC (permalink / raw
To: Geert Uytterhoeven
Cc: Rob Herring, Kishon Vijay Abraham I, Sergei Shtylyov, devicetree,
linux-phy, linux-renesas-soc
On 10-05-21, 14:10, Geert Uytterhoeven wrote:
> Convert the Renesas R-Car Gen3 PCIe PHY Device Tree binding
> documentation to json-schema.
>
> Update the example to match reality.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-14 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-10 12:10 [PATCH] dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema Geert Uytterhoeven
2021-05-11 19:50 ` Rob Herring
2021-05-14 10:34 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).