Linux-Dash Archive mirror
 help / color / mirror / Atom feed
From: Chema Gonzalez <chema@google.com>
To: Eric Blake <eblake@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, dash@vger.kernel.org
Subject: Re: [PATCH dash] [BUILTIN] ensure LC_COLLATE is not overriden
Date: Fri, 22 Aug 2014 16:08:49 -0700	[thread overview]
Message-ID: <CA+ZOOTP5-yygPphpBArwyw+xzgDr_zGHNW+MdaPs_Y+6_MAC6A@mail.gmail.com> (raw)
In-Reply-To: <53E1110D.7050309@redhat.com>

I finally managed to test a FreeBSD 10.0 host, and it seems to respect
LC_ALL before LANG.

Next patch includes just setting LC_ALL (which trumps LC_COLLATE).

-Chema


On Tue, Aug 5, 2014 at 10:14 AM, Eric Blake <eblake@redhat.com> wrote:
> On 08/05/2014 11:12 AM, Chema Gonzalez wrote:
>>> Setting LC_ALL= to the empty string risks implementation-defined
>>> behavior.  Also, LC_ALL overrides LANG and LC_COLLATE.  It should be
>>> sufficient to merely do:
>>>
>>>         }}' $temp | LC_ALL=C sort -k 1,1 | tee $temp2 | awk '{
>>
>> Maybe:
>>     }}' $temp | LC_ALL=C LANG=C sort -k 1,1 | tee $temp2 | awk '{
>
> No need to specify LANG=C when LC_ALL is set.  I stand by my shorter line.
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

  parent reply	other threads:[~2014-08-22 23:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 16:40 [PATCH dash] [BUILTIN] ensure LC_COLLATE is not overriden Chema Gonzalez
2014-08-05 17:00 ` Jérémie Courrèges-Anglas
2014-08-05 17:11   ` Chema Gonzalez
2014-08-05 17:09 ` Eric Blake
2014-08-05 17:12   ` Chema Gonzalez
2014-08-05 17:14     ` Eric Blake
2014-08-05 17:19       ` Chema Gonzalez
2014-08-05 17:30         ` Eric Blake
2014-08-22 23:08       ` Chema Gonzalez [this message]
2014-08-22 23:08 ` [PATCH dash v2] " Chema Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+ZOOTP5-yygPphpBArwyw+xzgDr_zGHNW+MdaPs_Y+6_MAC6A@mail.gmail.com \
    --to=chema@google.com \
    --cc=dash@vger.kernel.org \
    --cc=eblake@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).