From: Harald van Dijk <harald@gigawatt.nl>
To: David Binderman <dcb314@hotmail.com>,
"dash@vger.kernel.org" <dash@vger.kernel.org>
Subject: Re: dash-0.5.8 bug report
Date: Fri, 21 Nov 2014 18:38:10 +0100 [thread overview]
Message-ID: <546F7882.8030309@gigawatt.nl> (raw)
In-Reply-To: <DUB128-W26B546CDE4201C1F19CEC39C770@phx.gbl>
On 21/11/2014 14:55, David Binderman wrote:
> Hello there,
>
> eval.c:273:19: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>
> if (!exitstatus == isor)
>
> Maybe
>
> if (exitstatus != isor)
>
> was intended.
This looks correct to me. isor represents the type of command
composition. It can be 0 (&&), 1 (||) or 2 (;). If isor == 0, the second
command should not be executed if exitstatus != 0. If isor == 1, the
second command should not be executed if exitstatus == 0. If isor == 2,
the second command should be executed.
Cheers,
Harald van Dijk
prev parent reply other threads:[~2014-11-21 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 13:55 dash-0.5.8 bug report David Binderman
2014-11-21 17:38 ` Harald van Dijk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F7882.8030309@gigawatt.nl \
--to=harald@gigawatt.nl \
--cc=dash@vger.kernel.org \
--cc=dcb314@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).