From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
linux-cxl@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Shiyang Ruan <ruansy.fnst@fujitsu.com>,
Jonathan Cameron <Jonathan.Cameron@huwei.com>
Subject: Re: [PATCH v6 4/4] cxl/core: Add region info to cxl_general_media and cxl_dram events
Date: Wed, 8 May 2024 09:54:58 -0700 [thread overview]
Message-ID: <ZjuuFX81dlAaRn4c@aschofie-mobl2> (raw)
In-Reply-To: <66352769c2394_1aefb29467@dwillia2-mobl3.amr.corp.intel.com.notmuch>
On Fri, May 03, 2024 at 11:05:29AM -0700, Dan Williams wrote:
> alison.schofield@ wrote:
> > From: Alison Schofield <alison.schofield@intel.com>
> >
> > User space may need to know which region, if any, maps the DPAs
> > (device physical addresses) reported in a cxl_general_media or
> > cxl_dram event. Since the mapping can change, the kernel provides
> > this information at the time the event occurs. This informs user
> > space that at event <timestamp> this <region> mapped this <DPA>
> > to this <HPA>.
> >
> > Add the same region info that is included in the cxl_poison trace
> > event: the DPA->HPA translation, region name, and region uuid.
> >
> > The new fields are inserted in the trace event and no existing
> > fields are modified. If the DPA is not mapped, user will see:
> > hpa=ULLONG_MAX, region="", and uuid=0
> >
> > This work must be protected by dpa_rwsem & region_rwsem since
> > it is looking up region mappings.
> >
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
> [..]
> > diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> > index 03fa6d50d46f..5342755777cc 100644
> > --- a/include/linux/cxl-event.h
> > +++ b/include/linux/cxl-event.h
> > @@ -91,11 +91,21 @@ struct cxl_event_mem_module {
> > u8 reserved[0x3d];
> > } __packed;
> >
> > +/*
> > + * General Media or DRAM Event Common Fields
> > + * - provides common access to phys_addr
> > + */
> > +struct cxl_event_common {
> > + struct cxl_event_record_hdr hdr;
> > + __le64 phys_addr;
> > +} __packed;
> > +
> > union cxl_event {
> > struct cxl_event_generic generic;
> > struct cxl_event_gen_media gen_media;
> > struct cxl_event_dram dram;
> > struct cxl_event_mem_module mem_module;
> > + struct cxl_event_common common;
>
> I think we should rename this. As I was doing one last once-over my
> brain went "wait, there's no physical address in the Common Event
> Record".
>
> So at a minimum call this "media_hdr" to match the style of
> cxl_event_record_hdr.
>
> Now I say "minimum" because 'struct cxl_event_gen_media' and 'struct
> cxl_event_dram' should be including that struct in their definition to
> make it impossible that they have different definitions. I.e. I am not a
> fan of creating a new 'struct cxl_event_media_hdr' that is only consumed
> by 'union cxl_event'.
>
> The "maximum" would be to combine these definitions into one common
> flexible format to maximize shared definitions, something like the
> below, but the thrash it would cause is probably on the same order as
> just adding a 'struct cxl_event_media_hdr media_hdr' member to existing
> 'struct cxl_event_gen_media' and 'struct cxl_event_dram', fixup all the
> users and call it a day,
I've added this to my queue to fixup.
Thanks for the review.
-- Alison
>
> struct cxl_event_media {
> struct cxl_event_record_hdr hdr;
> struct_group_tagged(cxl_event_media_hdr, media_hdr,
> __le64 phys_addr,
> u8 descriptor,
> u8 type,
> u8 transaction_type,
> u8 validity_flags[2],
> u8 channel,
> u8 rank,
> };
> union {
> struct_group(general,
> u8 device[3],
> u8 component_id[CXL_EVENT_GEN_MED_COMP_ID_SIZE],
> u8 gen_reserved[46],
> );
> struct_group(media,
> u8 nibble_mask[3],
> u8 bank_group,
> u8 bank,
> u8 row[3],
> u8 column[2],
> u8 correction_mask[CXL_EVENT_DER_CORRECTION_MASK_SIZE],
> u8 dram_reserved[0x17],
> );
> };
> } __packed;
prev parent reply other threads:[~2024-05-08 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 17:28 [PATCH v6 0/4] Add DPA->HPA translation to dram & general_media events alison.schofield
2024-04-30 17:28 ` [PATCH v6 1/4] cxl/trace: Correct DPA field masks for general_media & dram events alison.schofield
2024-04-30 17:28 ` [PATCH v6 2/4] cxl/region: Move cxl_dpa_to_region() work to the region driver alison.schofield
2024-04-30 17:28 ` [PATCH v6 3/4] cxl/region: Move cxl_trace_hpa() " alison.schofield
2024-04-30 17:28 ` [PATCH v6 4/4] cxl/core: Add region info to cxl_general_media and cxl_dram events alison.schofield
2024-05-03 18:05 ` Dan Williams
2024-05-03 18:08 ` Dan Williams
2024-05-08 16:54 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjuuFX81dlAaRn4c@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=Jonathan.Cameron@huwei.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=ruansy.fnst@fujitsu.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).