From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org,
Derick Marks <derick.w.marks@intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] cxl: Fix use of phys_to_target_node() outside of init section
Date: Thu, 21 Mar 2024 13:09:08 +0100 [thread overview]
Message-ID: <ZfwjZMJMNUpWXZN8@rric.localdomain> (raw)
In-Reply-To: <65fa2c219548f_aa2229499@dwillia2-mobl3.amr.corp.intel.com.notmuch>
On 19.03.24 17:21:53, Dan Williams wrote:
> Robert Richter wrote:
> > Hi Dan,
> >
> > patch below. I have not included it into v2 of the SRAT/CEDT changes
> > as it is cxl specific and can be applied separately.
> >
> > Thanks,
> >
> > -Robert
> >
> >
> > On 18.03.24 14:26:41, Dan Williams wrote:
> > > It should also be the case that cxl_acpi needs this:
> > >
> > > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> > > index 67998dbd1d46..1bf25185c35b 100644
> > > --- a/drivers/cxl/Kconfig
> > > +++ b/drivers/cxl/Kconfig
> > > @@ -6,6 +6,7 @@ menuconfig CXL_BUS
> > > select FW_UPLOAD
> > > select PCI_DOE
> > > select FIRMWARE_TABLE
> > > + select NUMA_KEEP_MEMINFO if NUMA
> > > help
> > > CXL is a bus that is electrically compatible with PCI Express, but
> > > layers three protocols on that signalling (CXL.io, CXL.cache, and
> >
> > From be5b495980bae41d879909212db02dac0fba978e Mon Sep 17 00:00:00 2001
>
> Hi Robert,
>
> When you send inline patches like this can you remember to include a
> scissors line? That way tools like "b4 am" automatically know where to
> trim things. So add a line like the following:
>
> -- >8 --
>
> ...see "git mailinfo --help" for details.
Thanks for the inside on your patch processing. Will use that in the
future.
>
> Also note that if you reply with an updated patch in a series include
> the "vX NN/MM" suffix, like "Subject: [PATCH v3 2/3] ..." so that b4 am
> knows to perform a "partial reroll".
This patch is in addition to the other SRAT patches and can be applied
directly to the cxl tree. That is why there is no version update here.
But I replied to this series for reference. I saw the b4 shazam
--no-parent option, would that help here?
Thanks,
-Robert
>
> > From: Robert Richter <rrichter@amd.com>
> > Date: Tue, 19 Mar 2024 09:28:33 +0100
> > Subject: [PATCH] cxl: Fix use of phys_to_target_node() outside of init section
> >
> > The CXL driver uses both functions phys_to_target_node() and
> > memory_add_physaddr_to_nid(). The x86 architecture relies on the
> > NUMA_KEEP_MEMINFO kernel option to be set. Enable the option for the
> > driver accordingly.
> >
> > Suggested-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Robert Richter <rrichter@amd.com>
> > ---
> > drivers/cxl/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> > index 67998dbd1d46..6140b3529a29 100644
> > --- a/drivers/cxl/Kconfig
> > +++ b/drivers/cxl/Kconfig
> > @@ -6,6 +6,7 @@ menuconfig CXL_BUS
> > select FW_UPLOAD
> > select PCI_DOE
> > select FIRMWARE_TABLE
> > + select NUMA_KEEP_MEMINFO if (NUMA && X86)
> > help
> > CXL is a bus that is electrically compatible with PCI Express, but
> > layers three protocols on that signalling (CXL.io, CXL.cache, and
> > --
> > 2.39.2
> >
>
>
next prev parent reply other threads:[~2024-03-21 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 21:08 [PATCH 0/3] ACPI/NUMA: SRAT/CEDT fixes and updates Robert Richter
2024-03-18 21:09 ` [PATCH 1/3] x86/numa: Fix SRAT lookup for CFMWS ranges with numa_fill_memblks() Robert Richter
2024-03-18 21:14 ` Robert Richter
2024-03-18 21:31 ` Dan Williams
2024-03-18 21:26 ` Dan Williams
2024-03-18 21:50 ` Robert Richter
2024-03-19 11:54 ` [PATCH] cxl: Fix use of phys_to_target_node() outside of init section Robert Richter
2024-03-20 0:21 ` Dan Williams
2024-03-21 12:09 ` Robert Richter [this message]
2024-03-18 21:09 ` [PATCH 1/3] x86/numa: Fix SRAT lookup of CFMWS ranges with numa_fill_memblks() Robert Richter
2024-03-18 21:09 ` [PATCH 2/3] ACPI/NUMA: Print CXL Early Discovery Table (CEDT) Robert Richter
2024-03-18 21:30 ` Dan Williams
2024-03-18 21:55 ` Robert Richter
2024-03-18 21:09 ` [PATCH 3/3] ACPI/NUMA: Remove architecture dependent remainings Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfwjZMJMNUpWXZN8@rric.localdomain \
--to=rrichter@amd.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=derick.w.marks@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).