Linux-CXL Archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"kernel test robot" <lkp@intel.com>,
	Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] cxl/cper: Fix non-ACPI-APEI-GHES build
Date: Wed, 1 May 2024 11:51:24 -0700	[thread overview]
Message-ID: <66328f2caac87_1384629462@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20240501-cper-fix-0day-v1-1-c0b0056eafbc@intel.com>

Ira Weiny wrote:
> If ACPI_APEI_GHES is not configured the [un]register work functions are
> not properly declared.
> 
> Fix copy paste error.

Copy paste? I would just say:

0day notices that the cxl_cper_register_work() declaration in the
CONFIG_ACPI_APEI_GHES=n is broken, fix it to be typical nop stub.

> 
> Reported-by: kernel test robot <lkp@intel.com>

Checkpatch asks for Closes: tags these days:

Closes: http://lore.kernel.org/r/202405012230.6kXItWen-lkp@intel.com

With that,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

      reply	other threads:[~2024-05-01 18:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 18:40 [PATCH] cxl/cper: Fix non-ACPI-APEI-GHES build Ira Weiny
2024-05-01 18:51 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66328f2caac87_1384629462@dwillia2-mobl3.amr.corp.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).