Linux-CXL Archive mirror
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>
Cc: <dave@stgolabs.net>, <jonathan.cameron@huawei.com>,
	<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
	<ira.weiny@intel.com>, <dan.j.williams@intel.com>
Subject: Re: [PATCH] cxl: Fix white space issues in __cxl_coordinates_combine() function
Date: Thu, 25 Apr 2024 10:22:39 -0700	[thread overview]
Message-ID: <662a915f1887b_fa7d3294fc@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20240425170114.843163-1-dave.jiang@intel.com>

Dave Jiang wrote:
> Fix excessive indentation in __cxl_coordinates_combine() function.
> 
> Reported-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/cdat.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index bb83867d9fec..210a66743c38 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -518,15 +518,15 @@ static void __cxl_coordinates_combine(struct access_coordinate *out,
>  				      struct access_coordinate *c1,
>  				      struct access_coordinate *c2)
>  {
> -		if (c1->write_bandwidth && c2->write_bandwidth)
> -			out->write_bandwidth = min(c1->write_bandwidth,
> -						   c2->write_bandwidth);
> -		out->write_latency = c1->write_latency + c2->write_latency;
> +	if (c1->write_bandwidth && c2->write_bandwidth)
> +		out->write_bandwidth = min(c1->write_bandwidth,
> +					   c2->write_bandwidth);
> +	out->write_latency = c1->write_latency + c2->write_latency;
>  
> -		if (c1->read_bandwidth && c2->read_bandwidth)
> -			out->read_bandwidth = min(c1->read_bandwidth,
> -						  c2->read_bandwidth);
> -		out->read_latency = c1->read_latency + c2->read_latency;
> +	if (c1->read_bandwidth && c2->read_bandwidth)
> +		out->read_bandwidth = min(c1->read_bandwidth,
> +					  c2->read_bandwidth);
> +	out->read_latency = c1->read_latency + c2->read_latency;
>  }
>  
>  /**
> -- 
> 2.44.0
> 



      reply	other threads:[~2024-04-25 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 17:01 [PATCH] cxl: Fix white space issues in __cxl_coordinates_combine() function Dave Jiang
2024-04-25 17:22 ` Ira Weiny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=662a915f1887b_fa7d3294fc@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).