From: Ira Weiny <ira.weiny@intel.com>
To: Sangyun Kim <sangyun.kim@snu.ac.kr>, <linux-cxl@vger.kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
"Alison Schofield" <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Sangyun Kim <sangyun.kim@snu.ac.kr>
Subject: Re: [PATCH] cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h>
Date: Thu, 18 Apr 2024 15:02:31 -0700 [thread overview]
Message-ID: <6621987729944_3ddfb2941f@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20240417035043.2791431-1-sangyun.kim@snu.ac.kr>
Sangyun Kim wrote:
> The linux/cxl-event.h header file uses the u8, u16, and uuid_t types,
> but it doesn't include the necessary header files,
> <linux/types.h> and <linux/uuid.h>.
>
> Currently, cxl-event.h is only used by drivers/cxl/cxlmem.h,
> and it doesn't cause any errors because cxlmem.h indirectly
> includes the required types.
>
> However, cxl-event.h may be used by other CXL-related code in the future,
> so it's important to fix this issue by including the missing header files
> directly in cxl-event.h.
>
> Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
I pointed this out before.
https://lore.kernel.org/all/20240228-cxl-cper3-v1-1-6aa3f1343c6c@intel.com/
Dan suggested a fixes tag. I did not think it was technically required
but it would be nice. Regardless.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> include/linux/cxl-event.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> index 03fa6d50d46f..812ed16ffc2f 100644
> --- a/include/linux/cxl-event.h
> +++ b/include/linux/cxl-event.h
> @@ -3,6 +3,9 @@
> #ifndef _LINUX_CXL_EVENT_H
> #define _LINUX_CXL_EVENT_H
>
> +#include <linux/types.h>
> +#include <linux/uuid.h>
> +
> /*
> * Common Event Record Format
> * CXL rev 3.0 section 8.2.9.2.1; Table 8-42
> --
> 2.25.1
>
prev parent reply other threads:[~2024-04-18 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 3:50 [PATCH] cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h> Sangyun Kim
2024-04-18 22:02 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6621987729944_3ddfb2941f@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=sangyun.kim@snu.ac.kr \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).