From: Yan Zhao <yan.y.zhao@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: <arnd@arndb.de>, <guoren@kernel.org>, <bcain@quicinc.com>,
<jonas@southpole.se>, <stefan.kristiansson@saunalahti.fi>,
<shorne@gmail.com>, <linux-arch@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-csky@vger.kernel.org>,
<linux-hexagon@vger.kernel.org>, <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead of VA in pfn_to_virt
Date: Fri, 1 Mar 2024 07:01:58 +0800 [thread overview]
Message-ID: <ZeEM5gBd/eigWreZ@yzhao56-desk.sh.intel.com> (raw)
In-Reply-To: <CACRpkdZ_XUmW__y=8R3aJkci+h-pHRh8-xH7ZmfRyQ=jjCbajw@mail.gmail.com>
On Thu, Feb 29, 2024 at 02:34:35PM +0100, Linus Walleij wrote:
> On Wed, Jan 31, 2024 at 7:27 AM Yan Zhao <yan.y.zhao@intel.com> wrote:
>
> > Apply the page shift to PFN to get physical address for final VA.
> > The macro __va should take physical address instead of PFN as input.
> >
> > Fixes: 2d78057f0dd4 ("asm-generic/page.h: Make pfn accessors static inlines")
> > Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
>
> My bug, obviously. :(
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> I thought this was already applied with the other fixes, but maybe it
> was missed?
>
Hi Linus,
The other 3 in csky/hexagon/openrisc should have been applied in
https://lore.kernel.org/all/20240202140550.9886-1-yan.y.zhao@intel.com/.
This one in asm-generic is not, because Arnd said he is going to remove
the header as a whole soon.
I explained it in the change log :)
"The pfn_to_virt() in asm-generic/page.h is not touched in this patch as
it's referenced by page_to_virt() in that header while the whole header is
going to be removed as a whole due to no one including it."
Thanks
Yan
next prev parent reply other threads:[~2024-02-29 23:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 5:51 [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt Yan Zhao
2024-01-31 5:57 ` [PATCH 1/4] asm-generic/page.h: " Yan Zhao
2024-02-23 11:26 ` Guo Ren
2024-02-29 13:34 ` Linus Walleij
2024-02-29 23:01 ` Yan Zhao [this message]
2024-01-31 5:59 ` [PATCH 2/4] csky: " Yan Zhao
2024-02-23 11:26 ` Guo Ren
2024-01-31 6:00 ` [PATCH 3/4] Hexagon: " Yan Zhao
2024-01-31 6:01 ` [PATCH 4/4] openrisc: " Yan Zhao
2024-01-31 7:37 ` [PATCH 0/4] " Linus Walleij
2024-01-31 11:48 ` Arnd Bergmann
2024-02-01 0:01 ` Yan Zhao
2024-02-01 5:46 ` Arnd Bergmann
2024-02-01 10:46 ` Geert Uytterhoeven
2024-02-02 7:27 ` Arnd Bergmann
2024-02-02 1:02 ` Yan Zhao
2024-02-02 7:04 ` Arnd Bergmann
2024-02-02 14:09 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeEM5gBd/eigWreZ@yzhao56-desk.sh.intel.com \
--to=yan.y.zhao@intel.com \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=guoren@kernel.org \
--cc=jonas@southpole.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).