From: Leo Yan <leo.yan@linux.dev>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Guo Ren <guoren@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Huacai Chen <chenhuacai@kernel.org>,
Ming Wang <wangming01@loongson.cn>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org
Cc: Leo Yan <leo.yan@linux.dev>
Subject: [PATCH v1 0/4] perf parse-regs: Cleanup config and building
Date: Wed, 14 Feb 2024 19:39:43 +0800 [thread overview]
Message-ID: <20240214113947.240957-1-leo.yan@linux.dev> (raw)
Currently, the perf building enables register parsing based on the
target architecture has supported register feature.
Furthermore, the perf building system needs to maintain a variable
'NO_PERF_REGS' and defines macro 'HAVE_PERF_REGS_SUPPORT' for statically
compiling the tool.
As a result, the perf has no flexibilty for parsing register if an
architecture doesn't support it. And the source files use the macro
'HAVE_PERF_REGS_SUPPORT' to switch on and off the register parsing
related code, which is not a good practice.
This series is to remove the static building for register parsing. In
theory, we should can dynamically detect if an arch has support this
feature and functions can return errors when the feature is not
supported.
The first patch is to remove unused build configuration
CONFIG_PERF_REGS.
The second patch is to build perf register functions, without using the
macro 'HAVE_PERF_REGS_SUPPORT' to statically turn on or off code.
The third patch is to introduce a weak function arch__sample_reg_masks(),
this function can allow the target arch to return its sample register
list. With this change, we can totally remove the macro
'HAVE_PERF_REGS_SUPPORT' in the source file.
The forth patch is to clean up the Makefile for removing relevant
configuration and macro definition, as they are not useful anymore.
I tested this patch set on Arm64 and x86 for building and did a cross
register parsing ('perf record' on Arm64 and 'perf report' on x86).
Leo Yan (4):
perf build: Remove unused CONFIG_PERF_REGS
perf parse-regs: Always build perf register functions
perf parse-regs: Introduce a weak function arch__sample_reg_masks()
perf build: Cleanup perf register configuration
tools/perf/Makefile.config | 25 --------------
tools/perf/arch/arm/util/perf_regs.c | 7 +++-
tools/perf/arch/arm64/util/machine.c | 2 ++
tools/perf/arch/arm64/util/perf_regs.c | 7 +++-
tools/perf/arch/csky/util/perf_regs.c | 7 +++-
tools/perf/arch/loongarch/util/perf_regs.c | 7 +++-
tools/perf/arch/mips/util/perf_regs.c | 7 +++-
tools/perf/arch/powerpc/util/perf_regs.c | 7 +++-
tools/perf/arch/riscv/util/perf_regs.c | 7 +++-
tools/perf/arch/s390/util/perf_regs.c | 7 +++-
tools/perf/arch/x86/util/perf_regs.c | 7 +++-
tools/perf/util/parse-regs-options.c | 8 ++---
.../util/perf-regs-arch/perf_regs_aarch64.c | 4 ---
.../perf/util/perf-regs-arch/perf_regs_arm.c | 4 ---
.../perf/util/perf-regs-arch/perf_regs_csky.c | 4 ---
.../util/perf-regs-arch/perf_regs_loongarch.c | 4 ---
.../perf/util/perf-regs-arch/perf_regs_mips.c | 4 ---
.../util/perf-regs-arch/perf_regs_powerpc.c | 4 ---
.../util/perf-regs-arch/perf_regs_riscv.c | 4 ---
.../perf/util/perf-regs-arch/perf_regs_s390.c | 4 ---
.../perf/util/perf-regs-arch/perf_regs_x86.c | 4 ---
tools/perf/util/perf_regs.c | 11 ++++--
tools/perf/util/perf_regs.h | 34 +------------------
23 files changed, 67 insertions(+), 112 deletions(-)
--
2.34.1
next reply other threads:[~2024-02-14 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 11:39 Leo Yan [this message]
2024-02-14 11:39 ` [PATCH v1 1/4] perf build: Remove unused CONFIG_PERF_REGS Leo Yan
2024-02-14 11:39 ` [PATCH v1 2/4] perf parse-regs: Always build perf register functions Leo Yan
2024-02-14 11:39 ` [PATCH v1 3/4] perf parse-regs: Introduce a weak function arch__sample_reg_masks() Leo Yan
2024-02-14 11:39 ` [PATCH v1 4/4] perf build: Cleanup perf register configuration Leo Yan
2024-02-14 22:42 ` [PATCH v1 0/4] perf parse-regs: Cleanup config and building Ian Rogers
2024-02-15 6:32 ` Leo Yan
2024-02-16 19:42 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214113947.240957-1-leo.yan@linux.dev \
--to=leo.yan@linux.dev \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=chenhuacai@kernel.org \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=wangming01@loongson.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).