From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: syzbot <syzbot+0cb5bb0f4bf9e79db3b3@syzkaller.appspotmail.com>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, luto@kernel.org,
peterz@infradead.org, syzkaller-bugs@googlegroups.com,
tglx@linutronix.de,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH] padata: Disable BH when taking works lock on MT path
Date: Wed, 3 Apr 2024 17:25:10 -0400 [thread overview]
Message-ID: <w6w5o45557hrsdgwzpxa7fm7o3nufptc5eayymk4luarqsxrdd@qj6tpurky5uh> (raw)
In-Reply-To: <Zg0jEu5OsZaUFzn0@gondor.apana.org.au>
On Wed, Apr 03, 2024 at 05:36:18PM +0800, Herbert Xu wrote:
> On Mon, Apr 01, 2024 at 07:08:28AM -0700, syzbot wrote:
> >
> > syzbot found the following issue on:
> >
> > HEAD commit: 18737353cca0 Merge tag 'edac_urgent_for_v6.9_rc2' of git:/..
> > git tree: upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=15d605e5180000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=f64ec427e98bccd7
> > dashboard link: https://syzkaller.appspot.com/bug?extid=0cb5bb0f4bf9e79db3b3
> > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
>
> Strictly speaking this can't happen because for the time being
> padata_do_multithreaded cannot run at the same time as the old
> padata which occurs in BH context.
>
> But the simplest fix is to just disable BH:
>
> ---8<---
> As the old padata code can execute in softirq context, disable
> softirqs for the new padata_do_mutithreaded code too as otherwise
> lockdep will get antsy.
>
> Reported-by: syzbot+0cb5bb0f4bf9e79db3b3@syzkaller.appspotmail.com
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
prev parent reply other threads:[~2024-04-03 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 14:08 [syzbot] [crypto?] inconsistent lock state in padata_do_parallel (2) syzbot
2024-04-03 9:36 ` [PATCH] padata: Disable BH when taking works lock on MT path Herbert Xu
2024-04-03 21:25 ` Daniel Jordan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6w5o45557hrsdgwzpxa7fm7o3nufptc5eayymk4luarqsxrdd@qj6tpurky5uh \
--to=daniel.m.jordan@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=steffen.klassert@secunet.com \
--cc=syzbot+0cb5bb0f4bf9e79db3b3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).