From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, jarkko@kernel.org, ardb@kernel.org,
git@jvdsn.com, hkario@redhat.com, simo@redhat.com
Subject: Re: [PATCH v3 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues
Date: Fri, 26 Apr 2024 17:33:55 +0800 [thread overview]
Message-ID: <Zit1AwnkuuPZcwol@gondor.apana.org.au> (raw)
In-Reply-To: <20240418152445.2773042-1-stefanb@linux.ibm.com>
On Thu, Apr 18, 2024 at 11:24:43AM -0400, Stefan Berger wrote:
> The 1st patch fixes a byte ordering issue where ctx->private_key is
> currently passed to ecc_is_key_valid but the key is in reverse byte order.
> To solve this issue it introduces the variable 'priv', that is already used
> throughout the ecc and ecdh code bases for a private key in proper byte
> order, and calls ecc_is_key_valid with 'priv'. Note that ecc_gen_privkey
> also calls __ecc_is_key_valid with 'priv' already.
>
> The 2nd patch gets rid of the 'priv' variable wherever it is used to hold
> a private key (byte-swapped initialized from ctx->private_key) in proper
> byte order and uses ctx->private_key directly that is now initialized in
> proper byte order.
>
> Regards,
> Stefan
>
> v3:
> - Added Jarkko's A-b tag
> - Expanded on the description of changes to ecc_gen_privkey (2/2)
>
> v2:
> - Added missing zeroizing of priv variable (1/2)
> - Improved patch description (2/2)
>
>
>
>
> Stefan Berger (2):
> crypto: ecdh - Pass private key in proper byte order to check valid
> key
> crypto: ecdh & ecc - Initialize ctx->private_key in proper byte order
>
> crypto/ecc.c | 29 ++++++++++-------------------
> crypto/ecdh.c | 9 ++++++---
> include/crypto/internal/ecc.h | 3 ++-
> 3 files changed, 18 insertions(+), 23 deletions(-)
>
> --
> 2.43.0
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-04-26 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 15:24 [PATCH v3 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues Stefan Berger
2024-04-18 15:24 ` [PATCH v3 1/2] crypto: ecdh - Pass private key in proper byte order to check valid key Stefan Berger
2024-04-19 17:23 ` Stefan Berger
2024-04-26 9:14 ` Herbert Xu
2024-04-18 15:24 ` [PATCH v3 2/2] crypto: ecdh & ecc - Initialize ctx->private_key in proper byte order Stefan Berger
2024-04-19 10:49 ` [PATCH v3 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues Hubert Kario
2024-04-26 9:33 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zit1AwnkuuPZcwol@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=git@jvdsn.com \
--cc=hkario@redhat.com \
--cc=jarkko@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simo@redhat.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).