From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Akhil R <akhilrajeev@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-crypto@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] crypto: tegra-se - Convert to platform remove callback returning void
Date: Fri, 26 Apr 2024 17:29:46 +0800 [thread overview]
Message-ID: <Zit0Cg8nFs2HDBsN@gondor.apana.org.au> (raw)
In-Reply-To: <20240415073422.8274-2-u.kleine-koenig@pengutronix.de>
On Mon, Apr 15, 2024 at 09:34:21AM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this driver appeared in today's next. Given that I want to change struct
> platform_driver::remove soon (probably in next after the upcoming merge
> window), it would be great if the driver could be adapted immediately.
>
> Best regards
> Uwe
>
> drivers/crypto/tegra/tegra-se-main.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-04-26 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 7:34 [PATCH] crypto: tegra-se - Convert to platform remove callback returning void Uwe Kleine-König
2024-04-15 8:35 ` Akhil R
2024-04-26 9:29 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zit0Cg8nFs2HDBsN@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akhilrajeev@nvidia.com \
--cc=davem@davemloft.net \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).