From: Herbert Xu <herbert@gondor.apana.org.au>
To: Joachim Vandersmissen <git@jvdsn.com>
Cc: linux-crypto@vger.kernel.org, David Howells <dhowells@redhat.com>,
Simo Sorce <simo@redhat.com>,
Stephan Mueller <smueller@chronox.de>
Subject: Re: [PATCH 2/2] certs: Guard RSA signature verification self-test
Date: Thu, 18 Apr 2024 12:01:34 +0800 [thread overview]
Message-ID: <ZiCbHhvDLvDD75c5@gondor.apana.org.au> (raw)
In-Reply-To: <65bb88b5-5071-4836-9923-939218d9a883@jvdsn.com>
On Tue, Apr 16, 2024 at 08:39:28AM -0500, Joachim Vandersmissen wrote:
>
> I did consider that initially, but I was unsure if this was the right path.
> From a conceptual standpoint, this module doesn't need the RSA (or ECDSA)
> functionality. If the algorithm is not present, it would be perfectly valid
> for the module to do nothing. However, I'm not opposed to removing the
> current check and adding the select to the Kconfig.
>
> If I add a `select CRYPTO_RSA` to FIPS_SIGNATURE_SELFTEST, do you think I
> should do something similar for ECDSA as well (considering the other patch
> in this series)?
I think we should split the data out into individual files, leaving
only the test code in selftest.c. Each individual file could then
invoke the test function directly on its data.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-04-18 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 3:23 [PATCH 1/2] certs: Add ECDSA signature verification self-test Joachim Vandersmissen
2024-04-16 3:23 ` [PATCH 2/2] certs: Guard RSA " Joachim Vandersmissen
2024-04-16 8:59 ` Herbert Xu
2024-04-16 13:39 ` Joachim Vandersmissen
2024-04-18 4:01 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiCbHhvDLvDD75c5@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dhowells@redhat.com \
--cc=git@jvdsn.com \
--cc=linux-crypto@vger.kernel.org \
--cc=simo@redhat.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).