From: Herbert Xu <herbert@gondor.apana.org.au>
To: Aleksandr Mishin <amishin@t-argos.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Steve Lin <steven.lin1@broadcom.com>,
Rob Rice <rob.rice@broadcom.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] crypto: bcm/spu2 - Add buffer size check
Date: Thu, 28 Mar 2024 18:57:33 +0800 [thread overview]
Message-ID: <ZgVNHSZ8xmPqrSuL@gondor.apana.org.au> (raw)
In-Reply-To: <20240322205915.13305-1-amishin@t-argos.ru>
On Fri, Mar 22, 2024 at 11:59:15PM +0300, Aleksandr Mishin wrote:
> In spu2_dump_omd() value of ptr is increased by ciph_key_len
> instead of hash_iv_len which could lead to going beyond the
> buffer boundaries.
> Fix this bug by changing ciph_key_len to hash_iv_len.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
> ---
> v2: Fix commit message according to the Linux kernel rules
>
> drivers/crypto/bcm/spu2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-03-28 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 11:00 [PATCH] crypto: bcm/spu2 Aleksandr Mishin
2024-03-22 20:59 ` [PATCH v2] crypto: bcm/spu2 - Add buffer size check Aleksandr Mishin
2024-03-28 10:57 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgVNHSZ8xmPqrSuL@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=amishin@t-argos.ru \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=rob.rice@broadcom.com \
--cc=steven.lin1@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).