From: Herbert Xu <herbert@gondor.apana.org.au>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Wolneykien <manowar@altlinux.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: ecrdsa - Fix module auto-load on add_key
Date: Thu, 28 Mar 2024 18:55:34 +0800 [thread overview]
Message-ID: <ZgVMpr19vT9vEJBJ@gondor.apana.org.au> (raw)
In-Reply-To: <20240318004241.2925876-1-vt@altlinux.org>
On Mon, Mar 18, 2024 at 03:42:40AM +0300, Vitaly Chikunov wrote:
> Add module alias with the algorithm cra_name similar to what we have for
> RSA-related and other algorithms.
>
> The kernel attempts to modprobe asymmetric algorithms using the names
> "crypto-$cra_name" and "crypto-$cra_name-all." However, since these
> aliases are currently missing, the modules are not loaded. For instance,
> when using the `add_key` function, the hash algorithm is typically
> loaded automatically, but the asymmetric algorithm is not.
>
> Steps to test:
>
> 1. Cert is generated usings ima-evm-utils test suite with
> `gen-keys.sh`, example cert is provided below:
>
> $ base64 -d >test-gost2012_512-A.cer <<EOF
> MIIB/DCCAWagAwIBAgIUK8+whWevr3FFkSdU9GLDAM7ure8wDAYIKoUDBwEBAwMFADARMQ8wDQYD
> VQQDDAZDQSBLZXkwIBcNMjIwMjAxMjIwOTQxWhgPMjA4MjEyMDUyMjA5NDFaMBExDzANBgNVBAMM
> BkNBIEtleTCBoDAXBggqhQMHAQEBAjALBgkqhQMHAQIBAgEDgYQABIGALXNrTJGgeErBUOov3Cfo
> IrHF9fcj8UjzwGeKCkbCcINzVUbdPmCopeJRHDJEvQBX1CQUPtlwDv6ANjTTRoq5nCk9L5PPFP1H
> z73JIXHT0eRBDVoWy0cWDRz1mmQlCnN2HThMtEloaQI81nTlKZOcEYDtDpi5WODmjEeRNQJMdqCj
> UDBOMAwGA1UdEwQFMAMBAf8wHQYDVR0OBBYEFCwfOITMbE9VisW1i2TYeu1tAo5QMB8GA1UdIwQY
> MBaAFCwfOITMbE9VisW1i2TYeu1tAo5QMAwGCCqFAwcBAQMDBQADgYEAmBfJCMTdC0/NSjz4BBiQ
> qDIEjomO7FEHYlkX5NGulcF8FaJW2jeyyXXtbpnub1IQ8af1KFIpwoS2e93LaaofxpWlpQLlju6m
> KYLOcO4xK3Whwa2hBAz9YbpUSFjvxnkS2/jpH2MsOSXuUEeCruG/RkHHB3ACef9umG6HCNQuAPY=
> EOF
>
> 2. Optionally, trace module requests with: trace-cmd stream -e module &
>
> 3. Trigger add_key call for the cert:
>
> # keyctl padd asymmetric "" @u <test-gost2012_512-A.cer
> 939910969
> # lsmod | head -3
> Module Size Used by
> ecrdsa_generic 16384 0
> streebog_generic 28672 0
>
> Repored-by: Paul Wolneykien <manowar@altlinux.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
> crypto/ecrdsa.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-03-28 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 0:42 [PATCH] crypto: ecrdsa - Fix module auto-load on add_key Vitaly Chikunov
2024-03-21 14:38 ` Stefan Berger
2024-03-28 10:55 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgVMpr19vT9vEJBJ@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manowar@altlinux.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).