From: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, Ruud.Derwig@synopsys.com,
manjunath.hadli@vayavyalabs.com, bhoomikak@vayavyalabs.com
Subject: Re: [PATCH v3 3/7] Add SPAcc ahash support
Date: Thu, 16 May 2024 08:41:57 +0530 [thread overview]
Message-ID: <CALxtO0myn63AwPh4vck7fpuJcttPJYLBM3TpsyBAexCMSa4GcQ@mail.gmail.com> (raw)
In-Reply-To: <Zj3Ut7ToXihFEDip@gondor.apana.org.au>
Hi Herbert,
The SPAcc crypto accelerator has the below design
1. The SPAcc does not allow us to read internal context (including
the intermediate hash).
The hardware context is inaccessible for security reasons.
2. SPAcc has multiple hardware contexts and every request uses a hardware
context that's obtained using 'spacc_open' and released with
'spacc_close'.
The export/import is supposed to save the intermediate hash and
since SPAcc hardware
does not provide that, I was using it to save my driver state. This
is redundant and I tested
the same by removing it from export/import. An empty import/export
function is what I
have in the latest driver code and that works for me.
Appreciate your inputs.
Warm regards,
PK
On Fri, May 10, 2024 at 1:33 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Tue, May 07, 2024 at 09:49:57AM +0530, Pavitrakumar Managutte wrote:
> >
> > About the export function, yes its hash state that's present inside
> > "spacc_crypto_ctx".
>
> Please show me exactly where the partial hash state is stored in the
> request context because I couldn't find the spot. It can't be in
> spacc_crypto_ctx as that is the tfm context and shared by multiple
> reqeusts.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-05-16 3:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 4:25 [PATCH v3 0/7] Add SPAcc crypto driver support Pavitrakumar M
2024-04-26 4:25 ` [PATCH v3 1/7] Add SPAcc Skcipher support Pavitrakumar M
2024-04-26 4:25 ` [PATCH v3 2/7] Enable SPAcc AUTODETECT Pavitrakumar M
2024-04-26 4:25 ` [PATCH v3 3/7] Add SPAcc ahash support Pavitrakumar M
2024-05-03 10:29 ` Herbert Xu
2024-05-07 4:19 ` Pavitrakumar Managutte
2024-05-10 8:03 ` Herbert Xu
2024-05-16 3:11 ` Pavitrakumar Managutte [this message]
2024-05-16 3:15 ` Herbert Xu
2024-05-16 3:50 ` Pavitrakumar Managutte
[not found] ` <CALxtO0mz6ehEowBr94MZqG3+P9tV1ZaomP5K3n1F2VSuRzn=1A@mail.gmail.com>
2024-05-21 2:13 ` Herbert Xu
2024-04-26 4:25 ` [PATCH v3 4/7] Add SPAcc aead support Pavitrakumar M
2024-04-26 4:25 ` [PATCH v3 5/7] Add SPAcc Kconfig and Makefile Pavitrakumar M
2024-04-26 4:25 ` [PATCH v3 6/7] Add SPAcc node zynqmp dts Pavitrakumar M
2024-04-26 4:25 ` [PATCH v3 7/7] Enable Driver compilation in crypto Kconfig and Makefile Pavitrakumar M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALxtO0myn63AwPh4vck7fpuJcttPJYLBM3TpsyBAexCMSa4GcQ@mail.gmail.com \
--to=pavitrakumarm@vayavyalabs.com \
--cc=Ruud.Derwig@synopsys.com \
--cc=bhoomikak@vayavyalabs.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=manjunath.hadli@vayavyalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).