Linux-Crypto Archive mirror
 help / color / mirror / Atom feed
From: "Stefan Kanthak" <stefan.kanthak@nexgo.de>
To: <linux-kernel@vger.kernel.org>>, <linux-crypto@vger.kernel.org>
Cc: <tim.c.chen@linux.intel.com>, <sean.m.gulley@intel.com>
Subject: [PATCH 2/2] crypto: s(h)aving 16 byte constant off arch/x86/crypto/sha1_ni_asm.S
Date: Mon, 8 Apr 2024 11:38:56 +0200	[thread overview]
Message-ID: <7F88D9730FA04A02ACCE0B47584422C5@H270> (raw)

Get rid of 16 byte constant, use shift instead of mask

--- -/arch/x86/crypto/sha1_ni_asm.S
+++ +/arch/x86/crypto/sha1_ni_asm.S
@@ -104,9 +104,9 @@
         add             DATA_PTR, NUM_BLKS      /* pointer to end of data */
 
         /* load initial hash values */
-        pinsrd          $3, 1*16(DIGEST_PTR), E0
+        pinsrd          $0, 1*16(DIGEST_PTR), E0
         movdqu          0*16(DIGEST_PTR), ABCD
-        pand            UPPER_WORD_MASK(%rip), E0
+        pslldq          $12, E0
         pshufd          $0x1B, ABCD, ABCD
 
         movdqa          PSHUFFLE_BYTE_FLIP_MASK(%rip), SHUF_MASK
@@ -297,8 +297,3 @@
 .align 16
 PSHUFFLE_BYTE_FLIP_MASK:
         .octa 0x000102030405060708090a0b0c0d0e0f
-
-.section        .rodata.cst16.UPPER_WORD_MASK, "aM", @progbits, 16
-.align 16
-UPPER_WORD_MASK:
-        .octa 0xFFFFFFFF000000000000000000000000

                 reply	other threads:[~2024-04-08  9:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F88D9730FA04A02ACCE0B47584422C5@H270 \
    --to=stefan.kanthak@nexgo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sean.m.gulley@intel.com \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).