From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Babis Chalios <bchalios@amazon.es>
Cc: Alexander Graf <graf@amazon.de>,
tytso@mit.edu, olivia@selenic.com, herbert@gondor.apana.org.au,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sudanl@amazon.com,
xmarcalx@amazon.co.uk, dwmw@amazon.co.uk
Subject: Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review easier
Date: Wed, 17 Apr 2024 15:19:44 +0200 [thread overview]
Message-ID: <3b469d35-ee27-42d4-8768-fc2ce9235196@kernel.org> (raw)
In-Reply-To: <Zh_Dpi630-LXJkJm@zx2c4.com>
On 17/04/2024 14:42, Jason A. Donenfeld wrote:
> On Wed, Apr 17, 2024 at 11:05:27AM +0200, Babis Chalios wrote:
>>
>>
>> On 17/4/24 10:35, Alexander Graf wrote:
>>>
>>> On 17.04.24 10:12, Babis Chalios wrote:
>>>> From: Sudan Landge <sudanl@amazon.com>
>>>>
>>>> Rearrage the functions of vmgenid to make the next commit,
>>>> which re-implements vmgenid as a platform driver, easier to review.
>>>>
>>>> Signed-off-by: Sudan Landge <sudanl@amazon.com>
>>>
>>>
>>> You can't sign off on behalf of someone else. The SoB here needs to be
>>> yours. If you are taking over this code from Sudan, I'd suggest to
>>> take over full ownership of it and put your own name as author and SoB
>>> in all patches.
>>>
>>
>> I thought about it and it seemed weird to me that I take over SoB and
>> authorship since I only touched one line in one of
>> the patches, but I will be taking over the patches, so I can do that if
>> that's the way we things are done.
>>
>> Does it make sense to at least add "Co-authored-by Sudan Landge
>> <sudanl@amazon.com>" here?
>
> Wait, what? No. If you didn't write these patches, you're not the
> author. Sudan is the author. However, if they passed through you, it's
> fine to add your S-o-b. You can even mention the trivial change you made
> between Sudan's S-o-b and your own.
>
It is not "fine" but it is a must. Regardless if you changed something
or not, you *must* provide your SoB since you generated the patch.
Babis, please read carefully submitting patches. Especially the DCO
part, but entire document is important.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-17 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:12 [PATCH v5 0/5] virt: vmgenid: Add devicetree bindings support Babis Chalios
2024-04-17 8:12 ` [PATCH v5 1/5] virt: vmgenid: rearrange code to make review easier Babis Chalios
2024-04-17 8:35 ` Alexander Graf
2024-04-17 9:05 ` Babis Chalios
2024-04-17 9:12 ` Alexander Graf
2024-04-17 12:42 ` Jason A. Donenfeld
2024-04-17 13:19 ` Krzysztof Kozlowski [this message]
2024-04-17 8:12 ` [PATCH v5 2/5] virt: vmgenid: change implementation to use a platform driver Babis Chalios
2024-04-17 8:12 ` [PATCH v5 3/5] virt: vmgenid: enable driver regardless of ACPI config Babis Chalios
2024-04-17 8:12 ` [PATCH v5 4/5] dt-bindings: rng: Add vmgenid support Babis Chalios
2024-04-17 8:41 ` Alexander Graf
2024-04-17 13:16 ` Krzysztof Kozlowski
2024-04-17 13:16 ` Krzysztof Kozlowski
2024-04-17 8:12 ` [PATCH v5 5/5] virt: vmgenid: add support for devicetree bindings Babis Chalios
2024-04-17 13:17 ` Krzysztof Kozlowski
2024-04-17 8:44 ` [PATCH v5 0/5] virt: vmgenid: Add devicetree bindings support Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b469d35-ee27-42d4-8768-fc2ce9235196@kernel.org \
--to=krzk@kernel.org \
--cc=Jason@zx2c4.com \
--cc=bchalios@amazon.es \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=graf@amazon.de \
--cc=herbert@gondor.apana.org.au \
--cc=krzk+dt@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=robh@kernel.org \
--cc=sudanl@amazon.com \
--cc=tytso@mit.edu \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).