From: Dave Hansen <dave.hansen@intel.com>
To: Eric Biggers <ebiggers@kernel.org>, x86@kernel.org
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/cpufeatures: Fix dependencies for GFNI, VAES, and VPCLMULQDQ
Date: Thu, 18 Apr 2024 07:24:10 -0700 [thread overview]
Message-ID: <1d28f1dc-0aea-4b91-9df7-1a6d3a291e2e@intel.com> (raw)
In-Reply-To: <20240417060434.47101-1-ebiggers@kernel.org>
On 4/16/24 23:04, Eric Biggers wrote:
> Fix cpuid_deps[] to list the correct dependencies for GFNI, VAES, and
> VPCLMULQDQ. These features don't depend on AVX512, and there exist CPUs
> that support these features but not AVX512. GFNI actually doesn't even
> depend on AVX.
>
> This prevents GFNI from being unnecessarily disabled if AVX is disabled
> to mitigate the GDS vulnerability.
Looks like the original commit was quite confused. Thanks for finding this.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
prev parent reply other threads:[~2024-04-18 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 6:04 [PATCH] x86/cpufeatures: Fix dependencies for GFNI, VAES, and VPCLMULQDQ Eric Biggers
2024-04-18 14:24 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d28f1dc-0aea-4b91-9df7-1a6d3a291e2e@intel.com \
--to=dave.hansen@intel.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).