From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
x86@kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev
Subject: Re: [PATCH v3] virt: tdx-guest: Handle GetQuote request error code
Date: Mon, 26 Feb 2024 18:24:00 -0800 [thread overview]
Message-ID: <d95be5da-151c-4f16-ae75-ac2fe27e1259@linux.intel.com> (raw)
In-Reply-To: <65dd3c87680e7_1138c729433@dwillia2-xfh.jf.intel.com.notmuch>
On 2/26/24 5:36 PM, Dan Williams wrote:
> Kuppuswamy Sathyanarayanan wrote:
>> The tdx-guest driver marshals quote requests via hypercall to have a
>> quoting enclave sign attestation evidence about the current state of
>> the TD. There are 2 possible failures, a transport failure (failure
>> to communicate with the quoting agent) and payload failure (a failed
>> quote). The driver only checks the former, update it to consider the
>> latter payload errors as well.
>>
>> Fixes: f4738f56d1dc ("virt: tdx-guest: Add Quote generation support using TSM_REPORTS")
>> Reported-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> Closes: https://lore.kernel.org/linux-coco/6bdf569c-684a-4459-af7c-4430691804eb@linux.intel.com/T/#u
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> Acked-by: Kai Huang <kai.huang@intel.com>
> Looks good to me:
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> ...if you decide you need a debug print here, or to differentiate the
> error codes based on transport vs payload error that can be a follow-on
> change.
Yes, will do. I will submit a pr_err() cleanup patch soon.
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
prev parent reply other threads:[~2024-02-27 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 22:42 [PATCH v3] virt: tdx-guest: Handle GetQuote request error code Kuppuswamy Sathyanarayanan
2024-02-27 1:36 ` Dan Williams
2024-02-27 2:24 ` Kuppuswamy Sathyanarayanan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d95be5da-151c-4f16-ae75-ac2fe27e1259@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).