From: Dov Murik <dovmurik@linux.ibm.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: linux-coco@lists.linux.dev,
Tobin Feldman-Fitzthum <tobin@linux.ibm.com>,
James Bottomley <jejb@linux.ibm.com>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
Dov Murik <dovmurik@linux.ibm.com>
Subject: Re: [RFC PATCH 3/3] virt: sevguest: Add support to get attestation report from SVSM
Date: Wed, 7 Jun 2023 20:05:13 +0300 [thread overview]
Message-ID: <c344c4ae-8a6f-a02d-453d-3980e28a64ec@linux.ibm.com> (raw)
In-Reply-To: <ZICu5fmlC8QeqFbO@redhat.com>
Thanks Daniel.
On 07/06/2023 19:23, Daniel P. Berrangé wrote:
> On Wed, Jun 07, 2023 at 06:06:46PM +0300, Dov Murik wrote:
>> Expose SNP_SVSM_ATTEST_SERVICES ioctl function which allows userspace to
>> retrieve SNP attestation report.
>>
>> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
>> ---
>> drivers/virt/coco/sevguest/sevguest.c | 95 +++++++++++++++++++++++++++
>> include/uapi/linux/sev-guest.h | 34 ++++++++++
>> 2 files changed, 129 insertions(+)
>
> Appreciate it is just an RFC right now, but the ioctl will eventually
> need documenting at Documentation/virt/coco/sev-guest.rst
>
You're right. Currently I developed this to help me test the SVSM
implementation of the attestation protocol. I'm sure there are other
debug leftovers in this series...
It was easy for me to add another function to the existing driver
(sev-guest), but maybe there's a benefit to separating this to a new
virt/coco/svsm-guest driver with its own ioctls, and autoload it when
kernel is running under SVSM.
I'll leave these options open; main focus should remain on SVSM itself
and its near future development directions.
-Dov
prev parent reply other threads:[~2023-06-07 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:06 [RFC PATCH 0/3] Retrieve SNP attestation from SVSM Dov Murik
2023-06-07 15:06 ` [RFC PATCH 1/3] x86/sev: Add __svsm_msr_protocol_2() which returns register values Dov Murik
2023-06-07 15:06 ` [RFC PATCH 2/3] x86/sev: Add snp_svsm_attest_services() Dov Murik
2023-06-07 15:06 ` [RFC PATCH 3/3] virt: sevguest: Add support to get attestation report from SVSM Dov Murik
2023-06-07 16:23 ` Daniel P. Berrangé
2023-06-07 17:05 ` Dov Murik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c344c4ae-8a6f-a02d-453d-3980e28a64ec@linux.ibm.com \
--to=dovmurik@linux.ibm.com \
--cc=berrange@redhat.com \
--cc=cclaudio@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-coco@lists.linux.dev \
--cc=tobin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).