Linux Confidential Computing Development
 help / color / mirror / Atom feed
From: Nikolay Borisov <nik.borisov@suse.com>
To: "Huang, Kai" <kai.huang@intel.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"x86@kernel.org" <x86@kernel.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [RFC PATCH] x86/virt/tdx: Disable KEXEC in the presence of TDX
Date: Fri, 19 Jan 2024 02:55:33 +0200	[thread overview]
Message-ID: <bd363091-22a6-4203-a7ec-b0ec4abfaf98@suse.com> (raw)
In-Reply-To: <7695034c0c7bf91532fb5cbd05d9a4b8cb77e70f.camel@intel.com>



On 19.01.24 г. 2:52 ч., Huang, Kai wrote:
> On Fri, 2024-01-19 at 02:49 +0200, Nikolay Borisov wrote:
>> [Adding Kirill as he has a series in flight about KEXEC]
>>
>> On 18.01.24 г. 23:31 ч., Huang, Kai wrote:
>>> On Thu, 2024-01-18 at 18:01 +0200, Nikolay Borisov wrote:
>>>> TDX doesn't currently support kexec so disable the latter when TDX
>>>> is detected at boot time. If kexec must absolutely be supported then
>>>> TDX can be disabled from the bios.
>>>>
>>>> Making this decision at run time rather than as a compile time option
>>>> allows distribution kernels to have both enabled and delegate to the
>>>> user whether they want to use TDX/Kexec.
>>>>
>>>> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
>>>
>>> Hi Nikolay,
>>>
>>> Thanks for the patch.
>>>
>>> I am working in progress on patches to make kexec() work with TDX.  I plan to
>>> send them out soon (e.g., next week), but I think perhaps your patch is
>>> reasonable before that is merged.
>>
>> I thought Kirill's series rectifies this ?
>>
> 
> No that's for TDX guest.

Well in this case shouldn't INTEL_TDX_GUEST also be gated on KEXEC_CORE 
being inoperable either via Kconfig option or via a similar approach to 
this one (if it's accepted)?

      reply	other threads:[~2024-01-19  0:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 16:01 [RFC PATCH] x86/virt/tdx: Disable KEXEC in the presence of TDX Nikolay Borisov
2024-01-18 21:31 ` Huang, Kai
2024-01-19  0:49   ` Nikolay Borisov
2024-01-19  0:52     ` Huang, Kai
2024-01-19  0:55       ` Nikolay Borisov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd363091-22a6-4203-a7ec-b0ec4abfaf98@suse.com \
    --to=nik.borisov@suse.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kai.huang@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).