From: Michael Kelley <mhklinux@outlook.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kys@microsoft.com" <kys@microsoft.com>,
"Cui, Dexuan" <decui@microsoft.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>
Subject: RE: [RFC RFT PATCH 0/4] Handle set_memory_XXcrypted() errors in hyperv
Date: Thu, 7 Mar 2024 20:25:28 +0000 [thread overview]
Message-ID: <SN6PR02MB415722AEC8C7BD3F7423A1B8D4202@SN6PR02MB4157.namprd02.prod.outlook.com> (raw)
In-Reply-To: <9e12c7139ab5b9b39c73a4069493d8d826b21702.camel@intel.com>
From: Edgecombe, Rick P <rick.p.edgecombe@intel.com> Sent: Thursday, March 7, 2024 11:12 AM
>
> On Thu, 2024-03-07 at 17:11 +0000, Michael Kelley wrote:
> > Using your patches plus the changes in my comments, I've
> > done most of the testing described above. The normal
> > paths work, and when I hack set_memory_encrypted()
> > to fail, the error paths correctly did not free the memory.
> > I checked both the ring buffer memory and the additional
> > vmalloc memory allocated by the netvsc driver and the uio
> > driver. The memory status can be checked after-the-fact
> > via /proc/vmmallocinfo and /proc/buddyinfo since these
> > are mostly large allocations. As expected, the drivers
> > output their own error messages after the failures to
> > teardown the GPADLs.
> >
> > I did not test the vmbus_disconnect() path since that
> > effectively kills the VM.
> >
> > I tested in a normal VM, and in an SEV-SNP VM. I didn't
> > specifically test in a TDX VM, but given that Hyper-V CoCo
> > guests run with a paravisor, the guest sees the same thing
> > either way.
>
> Thanks Michael! How would you feel about reposting the patches with
> your changes added? I think you have a very good handle on the part of
> the problem I understand, and additionally much more familiarity with
> these drivers.
Yes, I can submit a new version.
Michael
prev parent reply other threads:[~2024-03-07 20:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 2:10 [RFC RFT PATCH 0/4] Handle set_memory_XXcrypted() errors in hyperv Rick Edgecombe
2024-02-22 2:10 ` [RFC RFT PATCH 1/4] hv: Leak pages if set_memory_encrypted() fails Rick Edgecombe
2024-03-01 9:26 ` Wei Liu
2024-03-01 19:12 ` Edgecombe, Rick P
2024-03-01 19:00 ` Michael Kelley
2024-03-01 19:13 ` Edgecombe, Rick P
2024-03-01 20:21 ` Michael Kelley
2024-03-01 20:47 ` Edgecombe, Rick P
2024-02-22 2:10 ` [RFC RFT PATCH 2/4] hv: Track decrypted status in vmbus_gpadl Rick Edgecombe
2024-03-01 19:00 ` Michael Kelley
2024-02-22 2:10 ` [RFC RFT PATCH 3/4] hv_nstvsc: Don't free decrypted memory Rick Edgecombe
2024-03-01 19:01 ` Michael Kelley
2024-02-22 2:10 ` [RFC RFT PATCH 4/4] uio_hv_generic: " Rick Edgecombe
2024-03-01 19:01 ` Michael Kelley
2024-03-01 19:00 ` [RFC RFT PATCH 0/4] Handle set_memory_XXcrypted() errors in hyperv Michael Kelley
2024-03-07 17:11 ` Michael Kelley
2024-03-07 19:12 ` Edgecombe, Rick P
2024-03-07 20:25 ` Michael Kelley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR02MB415722AEC8C7BD3F7423A1B8D4202@SN6PR02MB4157.namprd02.prod.outlook.com \
--to=mhklinux@outlook.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).