From: Dov Murik <dovmurik@linux.ibm.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"amd-sev-snp@lists.suse.com" <amd-sev-snp@lists.suse.com>
Cc: Dov Murik <dovmurik@linux.ibm.com>
Subject: Re: SVSM Attestation and vTPM specification additions - v0.61
Date: Mon, 6 Mar 2023 12:33:10 +0200 [thread overview]
Message-ID: <4ec32298-be2f-c572-0cbf-6be3656944ac@linux.ibm.com> (raw)
In-Reply-To: <89f1527e-b710-8bd8-1059-4a0a51e4c0ab@amd.com>
Hi Tom,
On 08/02/2023 23:55, Tom Lendacky wrote:
> Attached is an updated draft version of the SVSM specification with
> feedback incorporated from the previous review. Please take a look and
> reply with any feedback you may have.
>
In section 7.1 (SVSM_ATTEST_SERVICES Call), Table 11 lists the field
"Attestation report buffer size (in bytes)", but this field is not used
in the description of the operation. There's also no register defined
to return the expected length of the report itself in case the supplied
report buffer is too small.
I suggest adding something like:
If the size of the SNP attestation report exceeds the size of the
supplied attestation report buffer, R8 will be set to the size of the
attestation report and the call will return SVSM_ERR_INVALID_PARAMETER.
(and fill RCX and RDX too in the response?)
-Dov
prev parent reply other threads:[~2023-03-06 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 21:55 SVSM Attestation and vTPM specification additions - v0.61 Tom Lendacky
2023-02-08 23:19 ` Dionna Amalie Glaze
2023-02-08 23:44 ` Tom Lendacky
2023-02-15 9:49 ` Jörg Rödel
2023-02-21 22:07 ` Tom Lendacky
2023-02-24 14:15 ` Jörg Rödel
2023-02-24 19:02 ` [EXTERNAL] " Jon Lange
2023-02-25 6:33 ` Jörg Rödel
2023-02-27 17:03 ` Jon Lange
2023-03-01 8:56 ` Jörg Rödel
2023-03-01 14:00 ` Tom Lendacky
2023-03-01 15:00 ` Tom Lendacky
2023-02-15 14:57 ` Tom Lendacky
2023-03-06 10:33 ` Dov Murik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec32298-be2f-c572-0cbf-6be3656944ac@linux.ibm.com \
--to=dovmurik@linux.ibm.com \
--cc=amd-sev-snp@lists.suse.com \
--cc=linux-coco@lists.linux.dev \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).