From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Dionna Glaze <dionnaglaze@google.com>,
Joerg Roedel <jroedel@suse.de>,
Michael Roth <michael.roth@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
Peter Gonda <pgonda@google.com>,
Tom Lendacky <Thomas.Lendacky@amd.com>,
linux-coco@lists.linux.dev, x86@kernel.org
Subject: [PATCH 00/11] SEV: Cleanup sev-guest a bit and add throttling
Date: Thu, 16 Feb 2023 13:41:09 +0100 [thread overview]
Message-ID: <20230216124120.26578-1-bp@alien8.de> (raw)
From: "Borislav Petkov (AMD)" <bp@alien8.de>
Hi,
so I've been looking at Dionna's patches adding the SEV guest throttling
and that request issuing spaghetti was getting on my nerves. And it
would've become even worse with more stuff piling ontop so here's
a first round of cleanups before adding more stuff and making it an
unmaintainable mess.
The final result is a lot easier to read with proper separation of
functionality between functions. I want to get rid of more input/output
params being passed back'n'forth and use a struct instead and Nikunj's
patches have stuff which goes in that direction but first things first.
After the cleanup, the new stuff being added is a lot less code and
almost trivial. But I've been staring at this for a while now so it
could be only me who thinks it is trivial now. But we'll see.
Initial smoke testing seems to work ok but I might've introduced some
funky bugs, ofc.
Comments and suggestions are appreciated, as always.
Thanks and thanks, Tom, for the help!
Borislav Petkov (AMD) (7):
virt/coco/sev-guest: Check SEV_SNP attribute at probe time
virt/coco/sev-guest: Simplify extended guest request handling
virt/coco/sev-guest: Remove the disable_vmpck label in
handle_guest_request()
virt/coco/sev-guest: Carve out the request issuing logic into a helper
virt/coco/sev-guest: Do some code style cleanups
virt/coco/sev-guest: Convert the sw_exit_info_2 checking to a
switch-case
crypto: ccp: Get rid of __sev_platform_init_locked()'s local function
pointer
Dionna Glaze (3):
virt/coco/sev-guest: Add throttling awareness
virt/coco/sev-guest: Double-buffer messages
x86/sev: Change snp_guest_issue_request()'s fw_err argument
Peter Gonda (1):
crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL
Documentation/virt/coco/sev-guest.rst | 20 ++-
arch/x86/include/asm/sev-common.h | 3 -
arch/x86/include/asm/sev.h | 4 +-
arch/x86/kernel/sev.c | 33 +++--
drivers/crypto/ccp/sev-dev.c | 22 +--
drivers/virt/coco/sev-guest/sev-guest.c | 169 +++++++++++++++---------
include/uapi/linux/psp-sev.h | 7 +
include/uapi/linux/sev-guest.h | 18 ++-
8 files changed, 181 insertions(+), 95 deletions(-)
--
2.35.1
next reply other threads:[~2023-02-16 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 12:41 Borislav Petkov [this message]
2023-02-16 12:41 ` [PATCH 01/11] crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL Borislav Petkov
2023-02-16 12:41 ` [PATCH 02/11] virt/coco/sev-guest: Check SEV_SNP attribute at probe time Borislav Petkov
2023-02-16 12:41 ` [PATCH 03/11] virt/coco/sev-guest: Simplify extended guest request handling Borislav Petkov
2023-02-16 16:43 ` Dionna Amalie Glaze
2023-02-16 12:41 ` [PATCH 04/11] virt/coco/sev-guest: Remove the disable_vmpck label in handle_guest_request() Borislav Petkov
2023-02-16 12:41 ` [PATCH 05/11] virt/coco/sev-guest: Carve out the request issuing logic into a helper Borislav Petkov
2023-02-16 12:45 ` [PATCH 06/11] virt/coco/sev-guest: Do some code style cleanups Borislav Petkov
2023-02-16 12:45 ` [PATCH 07/11] virt/coco/sev-guest: Convert the sw_exit_info_2 checking to a switch-case Borislav Petkov
2023-02-16 12:45 ` [PATCH 08/11] virt/coco/sev-guest: Add throttling awareness Borislav Petkov
2023-02-16 12:46 ` [PATCH 09/11] virt/coco/sev-guest: Double-buffer messages Borislav Petkov
2023-02-16 12:46 ` [PATCH 10/11] crypto: ccp: Get rid of __sev_platform_init_locked()'s local function pointer Borislav Petkov
2023-02-16 12:46 ` [PATCH 11/11] x86/sev: Change snp_guest_issue_request()'s fw_err argument Borislav Petkov
2023-02-16 16:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216124120.26578-1-bp@alien8.de \
--to=bp@alien8.de \
--cc=Thomas.Lendacky@amd.com \
--cc=dionnaglaze@google.com \
--cc=jroedel@suse.de \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=pgonda@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).