From: Jagadeesh Kona <quic_jkona@quicinc.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
"Satya Priya Kakitapalli" <quic_skakitap@quicinc.com>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH V2 RESEND 1/6] dt-bindings: clock: qcom: Add SM8650 video clock controller
Date: Fri, 26 Apr 2024 19:56:51 +0530 [thread overview]
Message-ID: <dfcaa665-512a-4c7c-8f5d-2ba819797ddb@quicinc.com> (raw)
In-Reply-To: <d160289a-d0c7-498e-88b2-89861ab9fa50@linaro.org>
On 4/25/2024 7:02 PM, Vladimir Zapolskiy wrote:
> Hi Jagadeesh,
>
> On 4/22/24 14:00, Jagadeesh Kona wrote:
>>
>> On 4/19/2024 2:31 AM, Vladimir Zapolskiy wrote:
>>> Hello Jagadeesh,
>>>
>>> On 3/25/24 08:07, Jagadeesh Kona wrote:
>>>>
>>>>
>>>> On 3/21/2024 6:42 PM, Dmitry Baryshkov wrote:
>>>>> On Thu, 21 Mar 2024 at 11:26, Jagadeesh Kona <quic_jkona@quicinc.com>
>>>>> wrote:
>>>>>>
>>>>>> Extend device tree bindings of SM8450 videocc to add support
>>>>>> for SM8650 videocc. While it at, fix the incorrect header
>>>>>> include in sm8450 videocc yaml documentation.
>>>>>>
>>>>>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>> ---
>>>>>> .../devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4
>>>>>> +++-
>>>>>> include/dt-bindings/clock/qcom,sm8450-videocc.h | 8
>>>>>> +++++++-
>>>>>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git
>>>>>> a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>>>>>> b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>>>>>> index bad8f019a8d3..79f55620eb70 100644
>>>>>> ---
>>>>>> a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>>>>>> +++
>>>>>> b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>>>>>> @@ -8,18 +8,20 @@ title: Qualcomm Video Clock & Reset Controller on
>>>>>> SM8450
>>>>>>
>>>>>> maintainers:
>>>>>> - Taniya Das <quic_tdas@quicinc.com>
>>>>>> + - Jagadeesh Kona <quic_jkona@quicinc.com>
>>>>>>
>>>>>> description: |
>>>>>> Qualcomm video clock control module provides the clocks, resets
>>>>>> and power
>>>>>> domains on SM8450.
>>>>>>
>>>>>> - See also:: include/dt-bindings/clock/qcom,videocc-sm8450.h
>>>>>> + See also:: include/dt-bindings/clock/qcom,sm8450-videocc.h
>>>>>
>>>>> This almost pleads to go to a separate patch. Fixes generally should
>>>>> be separated from the rest of the changes.
>>>>>
>>>>
>>>> Thanks Dmitry for your review.
>>>>
>>>> Sure, will separate this into a separate patch in next series.
>>>>
>>>>>>
>>>>>> properties:
>>>>>> compatible:
>>>>>> enum:
>>>>>> - qcom,sm8450-videocc
>>>>>> - qcom,sm8550-videocc
>>>>>> + - qcom,sm8650-videocc
>>>>>>
>>>>>> reg:
>>>>>> maxItems: 1
>>>>>> diff --git a/include/dt-bindings/clock/qcom,sm8450-videocc.h
>>>>>> b/include/dt-bindings/clock/qcom,sm8450-videocc.h
>>>>>> index 9d795adfe4eb..ecfebe52e4bb 100644
>>>>>> --- a/include/dt-bindings/clock/qcom,sm8450-videocc.h
>>>>>> +++ b/include/dt-bindings/clock/qcom,sm8450-videocc.h
>>>>>> @@ -1,6 +1,6 @@
>>>>>> /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>>> /*
>>>>>> - * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights
>>>>>> reserved.
>>>>>> + * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All
>>>>>> rights reserved.
>>>>>> */
>>>>>>
>>>>>> #ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SM8450_H
>>>>>> @@ -19,6 +19,11 @@
>>>>>> #define
>>>>>> VIDEO_CC_MVS1C_DIV2_DIV_CLK_SRC 9
>>>>>> #define VIDEO_CC_PLL0 10
>>>>>> #define VIDEO_CC_PLL1 11
>>>>>> +#define
>>>>>> VIDEO_CC_MVS0_SHIFT_CLK 12
>>>>>> +#define VIDEO_CC_MVS0C_SHIFT_CLK 13
>>>>>> +#define
>>>>>> VIDEO_CC_MVS1_SHIFT_CLK 14
>>>>>> +#define VIDEO_CC_MVS1C_SHIFT_CLK 15
>>>>>> +#define VIDEO_CC_XO_CLK_SRC 16
>>>>>
>>>>> Are these values applicable to sm8450?
>>>>>
>>>>
>>>> No, the shift clocks above are part of SM8650 only. To reuse the
>>>> existing SM8550 videocc driver for SM8650 and to register these shift
>>>> clocks for SM8650, I added them here.
>>>>
>>>
>>> In such case I'd strongly suggest to add a new qcom,sm8650-videocc.h
>>> file,
>>> and do #include qcom,sm8450-videocc.h in it, thus the new header will be
>>> really a short one.
>>>
>>> This will add pristine clarity.
>>>
>>
>> Thanks Vladimir for your suggestion. I believe adding a comment for
>> these set of clocks should be sufficient to indicate these clocks are
>> applicable only for SM8650, I can add the required comment and post the
>> next series. Please let me know if this works?
>
> Well, I didn't get any new information to abandon my suggestion, what is
> wrong with it or why is it less preferable?
>
> Even if you add a comment in the header file, it means that for SM8450
> platforms you'll begin to define inapplicable/unrelated macro for the
> platform, which opens a small risk of the misusage, and which can be
> easily avoided. I believe that the clarity is better for maintenance.
>
Yes, I agree. Will check and move these new clocks to a separate header
file in next series. Thanks!
Thanks,
Jagadeesh
next prev parent reply other threads:[~2024-04-26 14:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 9:25 [PATCH V2 RESEND 0/6] Add support for videocc and camcc on SM8650 Jagadeesh Kona
2024-03-21 9:25 ` [PATCH V2 RESEND 1/6] dt-bindings: clock: qcom: Add SM8650 video clock controller Jagadeesh Kona
2024-03-21 13:12 ` Dmitry Baryshkov
2024-03-25 6:07 ` Jagadeesh Kona
2024-03-25 6:38 ` Dmitry Baryshkov
2024-03-25 7:00 ` Jagadeesh Kona
2024-04-18 21:01 ` Vladimir Zapolskiy
2024-04-22 11:00 ` Jagadeesh Kona
2024-04-25 13:32 ` Vladimir Zapolskiy
2024-04-26 14:26 ` Jagadeesh Kona [this message]
2024-03-21 9:25 ` [PATCH V2 RESEND 2/6] clk: qcom: videocc-sm8550: Add support for videocc XO clk ares Jagadeesh Kona
2024-03-21 9:44 ` Dmitry Baryshkov
2024-03-21 11:36 ` Jagadeesh Kona
2024-03-23 0:30 ` Konrad Dybcio
2024-03-25 6:09 ` Jagadeesh Kona
2024-03-21 9:25 ` [PATCH V2 RESEND 3/6] clk: qcom: videocc-sm8550: Add SM8650 video clock controller Jagadeesh Kona
2024-03-21 10:03 ` Dmitry Baryshkov
2024-03-21 11:33 ` Jagadeesh Kona
2024-03-21 9:25 ` [PATCH V2 RESEND 4/6] dt-bindings: clock: qcom: Add SM8650 camera " Jagadeesh Kona
2024-03-21 10:20 ` Johan Hovold
2024-03-21 11:28 ` Jagadeesh Kona
2024-04-18 21:32 ` Vladimir Zapolskiy
2024-03-21 9:25 ` [PATCH V2 RESEND 5/6] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver Jagadeesh Kona
2024-03-21 10:26 ` Dmitry Baryshkov
2024-04-18 21:30 ` Vladimir Zapolskiy
2024-04-22 10:57 ` Jagadeesh Kona
2024-03-21 9:25 ` [PATCH V2 RESEND 6/6] arm64: dts: qcom: sm8650: Add video and camera clock controllers Jagadeesh Kona
2024-03-21 13:07 ` Vladimir Zapolskiy
2024-03-23 0:33 ` Konrad Dybcio
2024-04-18 20:56 ` Vladimir Zapolskiy
2024-03-21 13:13 ` Dmitry Baryshkov
2024-03-25 6:08 ` Jagadeesh Kona
2024-04-03 7:16 ` Jagadeesh Kona
2024-04-03 15:54 ` Dmitry Baryshkov
2024-04-04 5:13 ` Jagadeesh Kona
2024-04-04 5:30 ` Dmitry Baryshkov
2024-04-04 10:06 ` Jagadeesh Kona
2024-04-04 16:05 ` Dmitry Baryshkov
2024-04-05 6:00 ` Jagadeesh Kona
2024-04-05 7:44 ` Dmitry Baryshkov
2024-04-18 11:17 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfcaa665-512a-4c7c-8f5d-2ba819797ddb@quicinc.com \
--to=quic_jkona@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).