From: Rob Herring <robh@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: fixed: Define a preferred node name
Date: Tue, 30 Apr 2024 07:33:45 -0500 [thread overview]
Message-ID: <CAL_JsqJUMPMv8YuRgaWL+1it07vrn-U0nLckMkPPVF-QzJOcew@mail.gmail.com> (raw)
In-Reply-To: <9e1195f05f4eced0a158c49616deba6a.sboyd@kernel.org>
On Mon, Apr 29, 2024 at 7:11 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Rob Herring (Arm) (2024-04-25 11:38:09)
> > diff --git a/Documentation/devicetree/bindings/clock/fixed-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > index b0a4fb8256e2..d287bd092054 100644
> > --- a/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > @@ -11,6 +11,13 @@ maintainers:
> > - Stephen Boyd <sboyd@kernel.org>
> >
> > properties:
> > + $nodename:
> > + anyOf:
> > + - description: Preferred name is 'clock-<freq>'
>
> Is the preferred value of <freq> the clock-frequency property? Should
> say that explicitly somehow so that it's clear.
Yes, will add.
> > + pattern: "^clock-([0-9]+|[a-z0-9-]+)$"
> > + - description: Any name allowed
> > + deprecated: true
> > +
> > compatible:
> > const: fixed-clock
> >
> > diff --git a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> > index 8f71ab300470..962a1fe85416 100644
> > --- a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> > @@ -11,6 +11,14 @@ maintainers:
> > - Stephen Boyd <sboyd@kernel.org>
> >
> > properties:
> > + $nodename:
> > + anyOf:
> > + - description:
> > + Preferred name is 'clock-<freq>' if the input frequency is fixed
>
> Similar question here. Is <freq> supposed to be the output clock frequency?
Yes.
>
> > + pattern: "^clock-([0-9]+|[0-9a-z-]+)$"
> > + - description: Any name allowed
> > + deprecated: true
>
> I hope that deprecating this doesn't cause folks to try to clean things
> up and then break code that's depending on the node name to be the name
> of the clk. We don't want that string name to be important but it is
> sometimes.
Right. Leaving things as-is is the intent. We won't be enabling any
"no deprecated" mode by default when it is added.
Rob
prev parent reply other threads:[~2024-04-30 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:38 [PATCH] dt-bindings: clock: fixed: Define a preferred node name Rob Herring (Arm)
2024-04-30 0:11 ` Stephen Boyd
2024-04-30 12:33 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJUMPMv8YuRgaWL+1it07vrn-U0nLckMkPPVF-QzJOcew@mail.gmail.com \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).