From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks
Date: Thu, 9 May 2024 10:11:10 +0200 [thread overview]
Message-ID: <920b5d58-b636-4084-8ea8-9981ecd5c270@samsung.com> (raw)
In-Reply-To: <CAPLW+4nFp4AUpKdcsPTQ4gE3AByJU4WO+M34c3om+8AqTziAeg@mail.gmail.com>
On 08.05.2024 22:46, Sam Protsenko wrote:
> On Tue, May 7, 2024 at 1:53 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
>> clkdev entries") revealed that clock lookup is registered for all fixed
>> clocks. The mentioned commit added a check if the registered name is not
>> too long. This fails for some clocks registered for Exynos542x SoCs family.
>> This lookup is a left-over from early common clock framework days, not
>> really needed nowadays, so remove it to avoid further issues.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> Here is the fix for the mentioned 4d11c62ca8d7 commit, which fixes
>> booting of Exynos542x SoCs:
>> https://lore.kernel.org/all/20240507064434.3213933-1-m.szyprowski@samsung.com/
>>
>> This change is independent fix. I've tested it on all Exynos based boards
>> I have in my test lab. It would be great if someone could test it on
>> s3c64xx and s3c24xx based boards.
>> ---
> Thanks Marek, it fixes some warnings when booting the E850-96 board
> with current kernel-next (next-20240508), like:
>
> samsung_clk_register_fixed_rate: failed to register clock lookup
> for clk_rco_i3c_pmic
> ...
>
> But I guess 'ret' variable should be removed now, I'm seeing this
> build warning after applying this patch:
>
> drivers/clk/samsung/clk.c: In function 'samsung_clk_register_fixed_rate':
> drivers/clk/samsung/clk.c:142:20: warning: unused variable 'ret'
> [-Wunused-variable]
Indeed I've missed that. I will send v2 then.
> Also, maybe add corresponding "Fixes" tag?
The problem is which commit should be pointed there. The removed code
originates from commit 721c42a351b1 ("clk: samsung: add common clock
framework helper functions for Samsung platforms"), but that time such
workaround might have been required, so this doesn't match the 'Fixes'
tag usage.
> Other than that:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Tested-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> Thanks!
>
> [snip]
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2024-05-09 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240507065329eucas1p1b26d68384a4f076b31223ed099fd3a48@eucas1p1.samsung.com>
2024-05-07 6:53 ` [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks Marek Szyprowski
2024-05-07 16:35 ` André Draszik
2024-05-08 20:46 ` Sam Protsenko
2024-05-09 8:11 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=920b5d58-b636-4084-8ea8-9981ecd5c270@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).