From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
"Jagadeesh Kona" <quic_jkona@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: qcom: Add AHB clock for SM8150
Date: Thu, 2 May 2024 15:35:25 +0530 [thread overview]
Message-ID: <46e4000b-e588-d1b7-153e-047ed565565a@quicinc.com> (raw)
In-Reply-To: <CAA8EJpotvs3AOYO3ct=_JabBdYDops4Yfdutga9KBAbVPoZ5yw@mail.gmail.com>
On 5/1/2024 5:36 PM, Dmitry Baryshkov wrote:
> On Wed, 1 May 2024 at 11:32, Satya Priya Kakitapalli
> <quic_skakitap@quicinc.com> wrote:
>> SM8150 videocc needs AHB clock, so update the bindings for sm8150
>> to add the AHB clock.
>>
>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
> The tag is incorrect. The mentioned commit didn't add sm8150 bindings,
> so it didn't have a bug.
Thanks, will correct the tag.
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>> .../devicetree/bindings/clock/qcom,videocc.yaml | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> index 6999e36ace1b..68bac801adb0 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> @@ -75,7 +75,6 @@ allOf:
>> enum:
>> - qcom,sc7180-videocc
>> - qcom,sdm845-videocc
>> - - qcom,sm8150-videocc
>> then:
>> properties:
>> clocks:
>> @@ -101,6 +100,22 @@ allOf:
>> - const: bi_tcxo
>> - const: bi_tcxo_ao
>>
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sm8150-videocc
> Could you please extend the sm8250 case instead of defining a new one?
> Also could you please check if there is a clock (like ahb_clk_src)
> that uses bi_tcxo_ao instead of bi_tcxo? If so, we have to add this
> clock to the bindings even if the driver doesn't use/model it at this
> point.
There are no clocks using the bi_tcxo_ao on sm8150. Hence added separate
case for sm8150 instead of re-using sm8250.
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: AHB
>> + - description: Board XO source
>> + clock-names:
>> + items:
>> + - const: iface
>> + - const: bi_tcxo
>> +
>> - if:
>> properties:
>> compatible:
>>
>> --
>> 2.25.1
>>
>
next prev parent reply other threads:[~2024-05-02 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 8:32 [PATCH v3 0/2] Add DT support for video clock controller on SM8150 Satya Priya Kakitapalli
2024-05-01 8:32 ` [PATCH v3 1/2] dt-bindings: clock: qcom: Add AHB clock for SM8150 Satya Priya Kakitapalli
2024-05-01 12:06 ` Dmitry Baryshkov
2024-05-02 10:05 ` Satya Priya Kakitapalli (Temp) [this message]
2024-05-01 8:32 ` [PATCH v3 2/2] arm64: dts: qcom: sm8150: Add video clock controller node Satya Priya Kakitapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46e4000b-e588-d1b7-153e-047ed565565a@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).