From: Conor Dooley <conor@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-clk@vger.kernel.org, p.zabel@pengutronix.de,
mturquette@baylibre.com, sboyd@kernel.org,
lorenzo.bianconi83@gmail.com,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org,
dd@embedd.com, catalin.marinas@arm.com, will@kernel.org,
upstream@airoha.com, angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH 2/5] dt-bindings: reset: Add reset definitions for EN7581 SoC.
Date: Wed, 15 May 2024 17:27:28 +0100 [thread overview]
Message-ID: <20240515-imperfect-candle-6179aa934427@spud> (raw)
In-Reply-To: <acb6aa6fe473c485605c108e551d6d28ceb27a60.1715777643.git.lorenzo@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 3126 bytes --]
On Wed, May 15, 2024 at 02:58:48PM +0200, Lorenzo Bianconi wrote:
> Introduce reset binding definitions for reset controller available in
> the Airoha EN7581 clock module.
>
> Tested-by: Zhengping Zhang <zhengping.zhang@airoha.com>
Heh, what is there to test in a header of made up numbers?
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Just squash this into patch 1.
Cheers,
Conor.
> ---
> .../dt-bindings/reset/airoha,en7581-reset.h | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 include/dt-bindings/reset/airoha,en7581-reset.h
>
> diff --git a/include/dt-bindings/reset/airoha,en7581-reset.h b/include/dt-bindings/reset/airoha,en7581-reset.h
> new file mode 100644
> index 000000000000..1b7ee62ed164
> --- /dev/null
> +++ b/include/dt-bindings/reset/airoha,en7581-reset.h
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2024 AIROHA Inc
> + * Author: Lorenzo Bianconi <lorenzo@kernel.org>
> + */
> +
> +#ifndef __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7581_H_
> +#define __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7581_H_
> +
> +/* RST_CTRL2 */
> +#define EN7581_XPON_PHY_RST 0
> +#define EN7581_CPU_TIMER2_RST 2
> +#define EN7581_HSUART_RST 3
> +#define EN7581_UART4_RST 4
> +#define EN7581_UART5_RST 5
> +#define EN7581_I2C2_RST 6
> +#define EN7581_XSI_MAC_RST 7
> +#define EN7581_XSI_PHY_RST 8
> +#define EN7581_NPU_RST 9
> +#define EN7581_I2S_RST 10
> +#define EN7581_TRNG_RST 11
> +#define EN7581_TRNG_MSTART_RST 12
> +#define EN7581_DUAL_HSI0_RST 13
> +#define EN7581_DUAL_HSI1_RST 14
> +#define EN7581_HSI_RST 15
> +#define EN7581_DUAL_HSI0_MAC_RST 16
> +#define EN7581_DUAL_HSI1_MAC_RST 17
> +#define EN7581_HSI_MAC_RST 18
> +#define EN7581_WDMA_RST 19
> +#define EN7581_WOE0_RST 20
> +#define EN7581_WOE1_RST 21
> +#define EN7581_HSDMA_RST 22
> +#define EN7581_TDMA_RST 24
> +#define EN7581_EMMC_RST 25
> +#define EN7581_SOE_RST 26
> +#define EN7581_PCIE2_RST 27
> +#define EN7581_XFP_MAC_RST 28
> +#define EN7581_USB_HOST_P1_RST 29
> +#define EN7581_USB_HOST_P1_U3_PHY_RST 30
> +/* RST_CTRL1 */
> +#define EN7581_PCM1_ZSI_ISI_RST 32
> +#define EN7581_FE_PDMA_RST 33
> +#define EN7581_FE_QDMA_RST 34
> +#define EN7581_PCM_SPIWP_RST 36
> +#define EN7581_CRYPTO_RST 38
> +#define EN7581_TIMER_RST 40
> +#define EN7581_PCM1_RST 43
> +#define EN7581_UART_RST 44
> +#define EN7581_GPIO_RST 45
> +#define EN7581_GDMA_RST 46
> +#define EN7581_I2C_MASTER_RST 48
> +#define EN7581_PCM2_ZSI_ISI_RST 49
> +#define EN7581_SFC_RST 50
> +#define EN7581_UART2_RST 51
> +#define EN7581_GDMP_RST 52
> +#define EN7581_FE_RST 53
> +#define EN7581_USB_HOST_P0_RST 54
> +#define EN7581_GSW_RST 55
> +#define EN7581_SFC2_PCM_RST 57
> +#define EN7581_PCIE0_RST 58
> +#define EN7581_PCIE1_RST 59
> +#define EN7581_CPU_TIMER_RST 60
> +#define EN7581_PCIE_HB_RST 61
> +#define EN7581_XPON_MAC_RST 63
> +
> +#endif /* __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7581_H_ */
> --
> 2.45.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-15 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 12:58 [PATCH 0/5] Add reset support to EN7581 clk driver Lorenzo Bianconi
2024-05-15 12:58 ` [PATCH 1/5] dt-bindings: clock: airoha: Add reset support to EN7581 clock binding Lorenzo Bianconi
2024-05-15 16:23 ` Conor Dooley
2024-05-15 12:58 ` [PATCH 2/5] dt-bindings: reset: Add reset definitions for EN7581 SoC Lorenzo Bianconi
2024-05-15 16:27 ` Conor Dooley [this message]
2024-05-16 7:34 ` Lorenzo Bianconi
2024-05-16 9:46 ` AngeloGioacchino Del Regno
2024-05-16 11:14 ` Lorenzo Bianconi
2024-05-16 11:38 ` AngeloGioacchino Del Regno
2024-05-16 15:59 ` Lorenzo Bianconi
2024-05-15 12:58 ` [PATCH 3/5] arm64: dts: airoha: Add reset-controller support to EN7581 clock node Lorenzo Bianconi
2024-05-15 12:58 ` [PATCH 4/5] clk: en7523: Add reset-controller support for EN7581 SoC Lorenzo Bianconi
2024-05-16 9:50 ` AngeloGioacchino Del Regno
2024-05-16 11:22 ` Lorenzo Bianconi
2024-05-15 12:58 ` [PATCH 5/5] clk: en7523: Remove pcie prepare/unpreare callbacks " Lorenzo Bianconi
2024-05-16 9:51 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515-imperfect-candle-6179aa934427@spud \
--to=conor@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=dd@embedd.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nbd@nbd.name \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=upstream@airoha.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).