Linux-Clk Archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: ingenic: Remove OF_POPULATED flag to probe children
@ 2019-07-14 21:57 Paul Cercueil
  2019-07-16 16:48 ` Stephen Boyd
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2019-07-14 21:57 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: od, linux-clk, linux-kernel, Paul Cercueil

Remove the OF_POPULATED flag, in order to probe children when the
device node is compatible with "simple-mfd".

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/clk/ingenic/cgu.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clk/ingenic/cgu.c b/drivers/clk/ingenic/cgu.c
index 6e963031cd87..bf2a86cf1dbf 100644
--- a/drivers/clk/ingenic/cgu.c
+++ b/drivers/clk/ingenic/cgu.c
@@ -759,6 +759,12 @@ ingenic_cgu_new(const struct ingenic_cgu_clk_info *clock_info,
 
 	spin_lock_init(&cgu->lock);
 
+	/*
+	 * Remove the OF_POPULATED flag, in order to probe children when the
+	 * device node is compatible with "simple-mfd".
+	 */
+	of_node_clear_flag(np, OF_POPULATED);
+
 	return cgu;
 
 err_out_free:
-- 
2.21.0.593.g511ec345e18


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: ingenic: Remove OF_POPULATED flag to probe children
  2019-07-14 21:57 [PATCH] clk: ingenic: Remove OF_POPULATED flag to probe children Paul Cercueil
@ 2019-07-16 16:48 ` Stephen Boyd
  2019-07-16 16:57   ` Paul Cercueil
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2019-07-16 16:48 UTC (permalink / raw)
  To: Michael Turquette, Paul Cercueil
  Cc: od, linux-clk, linux-kernel, Paul Cercueil

Quoting Paul Cercueil (2019-07-14 14:57:15)
> Remove the OF_POPULATED flag, in order to probe children when the
> device node is compatible with "simple-mfd".

We have CLK_OF_DECLARE_DRIVER for this. Can you use that?

> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/clk/ingenic/cgu.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: ingenic: Remove OF_POPULATED flag to probe children
  2019-07-16 16:48 ` Stephen Boyd
@ 2019-07-16 16:57   ` Paul Cercueil
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2019-07-16 16:57 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Michael Turquette, od, linux-clk, linux-kernel



Le mar. 16 juil. 2019 à 12:48, Stephen Boyd <sboyd@kernel.org> a 
écrit :
> Quoting Paul Cercueil (2019-07-14 14:57:15)
>>  Remove the OF_POPULATED flag, in order to probe children when the
>>  device node is compatible with "simple-mfd".
> 
> We have CLK_OF_DECLARE_DRIVER for this. Can you use that?

Didn't see it. I'll send an updated patch then, thanks.


>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>>   drivers/clk/ingenic/cgu.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-16 16:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-14 21:57 [PATCH] clk: ingenic: Remove OF_POPULATED flag to probe children Paul Cercueil
2019-07-16 16:48 ` Stephen Boyd
2019-07-16 16:57   ` Paul Cercueil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).